From ba712ed5140ae97a09eeb467e655abe77bc5f05e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ville=20Skytt=C3=A4?= Date: Thu, 1 May 2025 00:26:10 +0300 Subject: [PATCH 1/2] Move huawei_lte sensor icons to icons.json where applicable (#143999) --- .../components/huawei_lte/icons.json | 131 ++++++++++++++++++ homeassistant/components/huawei_lte/sensor.py | 45 +----- 2 files changed, 132 insertions(+), 44 deletions(-) diff --git a/homeassistant/components/huawei_lte/icons.json b/homeassistant/components/huawei_lte/icons.json index 22eb345eba5923..862daa47cde32d 100644 --- a/homeassistant/components/huawei_lte/icons.json +++ b/homeassistant/components/huawei_lte/icons.json @@ -37,6 +37,137 @@ "default": "mdi:antenna" } }, + "sensor": { + "uptime": { + "default": "mdi:timer-outline" + }, + "wan_ip_address": { + "default": "mdi:ip" + }, + "wan_ipv6_address": { + "default": "mdi:ip" + }, + "cell_id": { + "default": "mdi:antenna" + }, + "cqi0": { + "default": "mdi:speedometer" + }, + "cqi1": { + "default": "mdi:speedometer" + }, + "enodeb_id": { + "default": "mdi:antenna" + }, + "lac": { + "default": "mdi:map-marker" + }, + "nei_cellid": { + "default": "mdi:antenna" + }, + "nrcqi0": { + "default": "mdi:speedometer" + }, + "nrcqi1": { + "default": "mdi:speedometer" + }, + "pci": { + "default": "mdi:antenna" + }, + "rac": { + "default": "mdi:map-marker" + }, + "tac": { + "default": "mdi:map-marker" + }, + "sms_unread": { + "default": "mdi:email-arrow-left" + }, + "current_day_transfer": { + "default": "mdi:arrow-up-down-bold" + }, + "current_month_download": { + "default": "mdi:download" + }, + "current_month_upload": { + "default": "mdi:upload" + }, + "wifi_clients_connected": { + "default": "mdi:wifi" + }, + "primary_dns_server": { + "default": "mdi:ip" + }, + "primary_ipv6_dns_server": { + "default": "mdi:ip" + }, + "secondary_dns_server": { + "default": "mdi:ip" + }, + "secondary_ipv6_dns_server": { + "default": "mdi:ip" + }, + "current_connection_duration": { + "default": "mdi:timer-outline" + }, + "current_connection_download": { + "default": "mdi:download" + }, + "current_download_rate": { + "default": "mdi:download" + }, + "current_connection_upload": { + "default": "mdi:upload" + }, + "current_upload_rate": { + "default": "mdi:upload" + }, + "total_connected_duration": { + "default": "mdi:timer-outline" + }, + "total_download": { + "default": "mdi:download" + }, + "total_upload": { + "default": "mdi:upload" + }, + "sms_deleted_device": { + "default": "mdi:email-minus" + }, + "sms_drafts_device": { + "default": "mdi:email-arrow-right-outline" + }, + "sms_inbox_device": { + "default": "mdi:email" + }, + "sms_capacity_device": { + "default": "mdi:email" + }, + "sms_outbox_device": { + "default": "mdi:email-arrow-right" + }, + "sms_unread_device": { + "default": "mdi:email-arrow-left" + }, + "sms_drafts_sim": { + "default": "mdi:email-arrow-right-outline" + }, + "sms_inbox_sim": { + "default": "mdi:email" + }, + "sms_capacity_sim": { + "default": "mdi:email" + }, + "sms_outbox_sim": { + "default": "mdi:email-arrow-right" + }, + "sms_unread_sim": { + "default": "mdi:email-arrow-left" + }, + "sms_messages_sim": { + "default": "mdi:email-arrow-left" + } + }, "switch": { "mobile_data": { "default": "mdi:signal-off", diff --git a/homeassistant/components/huawei_lte/sensor.py b/homeassistant/components/huawei_lte/sensor.py index e9270dfd6ff419..003ba1f98234ef 100644 --- a/homeassistant/components/huawei_lte/sensor.py +++ b/homeassistant/components/huawei_lte/sensor.py @@ -138,7 +138,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): "uptime": HuaweiSensorEntityDescription( key="uptime", translation_key="uptime", - icon="mdi:timer-outline", native_unit_of_measurement=UnitOfTime.SECONDS, device_class=SensorDeviceClass.DURATION, entity_category=EntityCategory.DIAGNOSTIC, @@ -146,14 +145,12 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): "WanIPAddress": HuaweiSensorEntityDescription( key="WanIPAddress", translation_key="wan_ip_address", - icon="mdi:ip", entity_category=EntityCategory.DIAGNOSTIC, entity_registry_enabled_default=True, ), "WanIPv6Address": HuaweiSensorEntityDescription( key="WanIPv6Address", translation_key="wan_ipv6_address", - icon="mdi:ip", entity_category=EntityCategory.DIAGNOSTIC, ), }, @@ -181,19 +178,16 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): "cell_id": HuaweiSensorEntityDescription( key="cell_id", translation_key="cell_id", - icon="mdi:antenna", entity_category=EntityCategory.DIAGNOSTIC, ), "cqi0": HuaweiSensorEntityDescription( key="cqi0", translation_key="cqi0", - icon="mdi:speedometer", entity_category=EntityCategory.DIAGNOSTIC, ), "cqi1": HuaweiSensorEntityDescription( key="cqi1", translation_key="cqi1", - icon="mdi:speedometer", entity_category=EntityCategory.DIAGNOSTIC, ), "dl_mcs": HuaweiSensorEntityDescription( @@ -230,7 +224,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): "enodeb_id": HuaweiSensorEntityDescription( key="enodeb_id", translation_key="enodeb_id", - icon="mdi:antenna", entity_category=EntityCategory.DIAGNOSTIC, ), "ims": HuaweiSensorEntityDescription( @@ -241,7 +234,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): "lac": HuaweiSensorEntityDescription( key="lac", translation_key="lac", - icon="mdi:map-marker", entity_category=EntityCategory.DIAGNOSTIC, ), "ltedlfreq": HuaweiSensorEntityDescription( @@ -279,7 +271,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): "nei_cellid": HuaweiSensorEntityDescription( key="nei_cellid", translation_key="nei_cellid", - icon="mdi:antenna", entity_category=EntityCategory.DIAGNOSTIC, ), "nrbler": HuaweiSensorEntityDescription( @@ -290,13 +281,11 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): "nrcqi0": HuaweiSensorEntityDescription( key="nrcqi0", translation_key="nrcqi0", - icon="mdi:speedometer", entity_category=EntityCategory.DIAGNOSTIC, ), "nrcqi1": HuaweiSensorEntityDescription( key="nrcqi1", translation_key="nrcqi1", - icon="mdi:speedometer", entity_category=EntityCategory.DIAGNOSTIC, ), "nrdlbandwidth": HuaweiSensorEntityDescription( @@ -376,7 +365,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): "pci": HuaweiSensorEntityDescription( key="pci", translation_key="pci", - icon="mdi:antenna", entity_category=EntityCategory.DIAGNOSTIC, ), "plmn": HuaweiSensorEntityDescription( @@ -387,7 +375,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): "rac": HuaweiSensorEntityDescription( key="rac", translation_key="rac", - icon="mdi:map-marker", entity_category=EntityCategory.DIAGNOSTIC, ), "rrc_status": HuaweiSensorEntityDescription( @@ -458,7 +445,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): "tac": HuaweiSensorEntityDescription( key="tac", translation_key="tac", - icon="mdi:map-marker", entity_category=EntityCategory.DIAGNOSTIC, ), "tdd": HuaweiSensorEntityDescription( @@ -522,7 +508,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): "UnreadMessage": HuaweiSensorEntityDescription( key="UnreadMessage", translation_key="sms_unread", - icon="mdi:email-arrow-left", ), }, ), @@ -536,7 +521,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): translation_key="current_day_transfer", native_unit_of_measurement=UnitOfInformation.BYTES, device_class=SensorDeviceClass.DATA_SIZE, - icon="mdi:arrow-up-down-bold", state_class=SensorStateClass.TOTAL, last_reset_item="CurrentDayDuration", last_reset_format_fn=format_last_reset_elapsed_seconds, @@ -546,7 +530,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): translation_key="current_month_download", native_unit_of_measurement=UnitOfInformation.BYTES, device_class=SensorDeviceClass.DATA_SIZE, - icon="mdi:download", state_class=SensorStateClass.TOTAL, last_reset_item="MonthDuration", last_reset_format_fn=format_last_reset_elapsed_seconds, @@ -556,7 +539,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): translation_key="current_month_upload", native_unit_of_measurement=UnitOfInformation.BYTES, device_class=SensorDeviceClass.DATA_SIZE, - icon="mdi:upload", state_class=SensorStateClass.TOTAL, last_reset_item="MonthDuration", last_reset_format_fn=format_last_reset_elapsed_seconds, @@ -580,32 +562,27 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): "CurrentWifiUser": HuaweiSensorEntityDescription( key="CurrentWifiUser", translation_key="wifi_clients_connected", - icon="mdi:wifi", state_class=SensorStateClass.MEASUREMENT, entity_category=EntityCategory.DIAGNOSTIC, ), "PrimaryDns": HuaweiSensorEntityDescription( key="PrimaryDns", translation_key="primary_dns_server", - icon="mdi:ip", entity_category=EntityCategory.DIAGNOSTIC, ), "PrimaryIPv6Dns": HuaweiSensorEntityDescription( key="PrimaryIPv6Dns", translation_key="primary_ipv6_dns_server", - icon="mdi:ip", entity_category=EntityCategory.DIAGNOSTIC, ), "SecondaryDns": HuaweiSensorEntityDescription( key="SecondaryDns", translation_key="secondary_dns_server", - icon="mdi:ip", entity_category=EntityCategory.DIAGNOSTIC, ), "SecondaryIPv6Dns": HuaweiSensorEntityDescription( key="SecondaryIPv6Dns", translation_key="secondary_ipv6_dns_server", - icon="mdi:ip", entity_category=EntityCategory.DIAGNOSTIC, ), }, @@ -618,14 +595,12 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): translation_key="current_connection_duration", native_unit_of_measurement=UnitOfTime.SECONDS, device_class=SensorDeviceClass.DURATION, - icon="mdi:timer-outline", ), "CurrentDownload": HuaweiSensorEntityDescription( key="CurrentDownload", translation_key="current_connection_download", native_unit_of_measurement=UnitOfInformation.BYTES, device_class=SensorDeviceClass.DATA_SIZE, - icon="mdi:download", state_class=SensorStateClass.TOTAL_INCREASING, ), "CurrentDownloadRate": HuaweiSensorEntityDescription( @@ -633,7 +608,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): translation_key="current_download_rate", native_unit_of_measurement=UnitOfDataRate.BYTES_PER_SECOND, device_class=SensorDeviceClass.DATA_RATE, - icon="mdi:download", state_class=SensorStateClass.MEASUREMENT, ), "CurrentUpload": HuaweiSensorEntityDescription( @@ -641,7 +615,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): translation_key="current_connection_upload", native_unit_of_measurement=UnitOfInformation.BYTES, device_class=SensorDeviceClass.DATA_SIZE, - icon="mdi:upload", state_class=SensorStateClass.TOTAL_INCREASING, ), "CurrentUploadRate": HuaweiSensorEntityDescription( @@ -649,7 +622,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): translation_key="current_upload_rate", native_unit_of_measurement=UnitOfDataRate.BYTES_PER_SECOND, device_class=SensorDeviceClass.DATA_RATE, - icon="mdi:upload", state_class=SensorStateClass.MEASUREMENT, ), "TotalConnectTime": HuaweiSensorEntityDescription( @@ -657,7 +629,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): translation_key="total_connected_duration", native_unit_of_measurement=UnitOfTime.SECONDS, device_class=SensorDeviceClass.DURATION, - icon="mdi:timer-outline", state_class=SensorStateClass.TOTAL_INCREASING, ), "TotalDownload": HuaweiSensorEntityDescription( @@ -665,7 +636,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): translation_key="total_download", native_unit_of_measurement=UnitOfInformation.BYTES, device_class=SensorDeviceClass.DATA_SIZE, - icon="mdi:download", state_class=SensorStateClass.TOTAL_INCREASING, ), "TotalUpload": HuaweiSensorEntityDescription( @@ -673,7 +643,6 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): translation_key="total_upload", native_unit_of_measurement=UnitOfInformation.BYTES, device_class=SensorDeviceClass.DATA_SIZE, - icon="mdi:upload", state_class=SensorStateClass.TOTAL_INCREASING, ), }, @@ -719,62 +688,50 @@ class HuaweiSensorEntityDescription(SensorEntityDescription): "LocalDeleted": HuaweiSensorEntityDescription( key="LocalDeleted", translation_key="sms_deleted_device", - icon="mdi:email-minus", ), "LocalDraft": HuaweiSensorEntityDescription( key="LocalDraft", translation_key="sms_drafts_device", - icon="mdi:email-arrow-right-outline", ), "LocalInbox": HuaweiSensorEntityDescription( key="LocalInbox", translation_key="sms_inbox_device", - icon="mdi:email", ), "LocalMax": HuaweiSensorEntityDescription( key="LocalMax", translation_key="sms_capacity_device", - icon="mdi:email", ), "LocalOutbox": HuaweiSensorEntityDescription( key="LocalOutbox", translation_key="sms_outbox_device", - icon="mdi:email-arrow-right", ), "LocalUnread": HuaweiSensorEntityDescription( key="LocalUnread", translation_key="sms_unread_device", - icon="mdi:email-arrow-left", ), "SimDraft": HuaweiSensorEntityDescription( key="SimDraft", translation_key="sms_drafts_sim", - icon="mdi:email-arrow-right-outline", ), "SimInbox": HuaweiSensorEntityDescription( key="SimInbox", translation_key="sms_inbox_sim", - icon="mdi:email", ), "SimMax": HuaweiSensorEntityDescription( key="SimMax", translation_key="sms_capacity_sim", - icon="mdi:email", ), "SimOutbox": HuaweiSensorEntityDescription( key="SimOutbox", translation_key="sms_outbox_sim", - icon="mdi:email-arrow-right", ), "SimUnread": HuaweiSensorEntityDescription( key="SimUnread", translation_key="sms_unread_sim", - icon="mdi:email-arrow-left", ), "SimUsed": HuaweiSensorEntityDescription( key="SimUsed", translation_key="sms_messages_sim", - icon="mdi:email-arrow-left", ), }, ), @@ -870,7 +827,7 @@ def icon(self) -> str | None: """Return icon for sensor.""" if self.entity_description.icon_fn: return self.entity_description.icon_fn(self.state) - return self.entity_description.icon + return super().icon @property def device_class(self) -> SensorDeviceClass | None: From 93f4f14b2a8f0e6f7c3ba4c177dcf3fcd5127e63 Mon Sep 17 00:00:00 2001 From: Jan-Philipp Benecke Date: Wed, 30 Apr 2025 23:45:41 +0200 Subject: [PATCH 2/2] Default backup encryption to true when updating only location retention (#143997) --- homeassistant/components/backup/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/homeassistant/components/backup/config.py b/homeassistant/components/backup/config.py index 75576105e92d4d..0c8a5c82f7ced0 100644 --- a/homeassistant/components/backup/config.py +++ b/homeassistant/components/backup/config.py @@ -202,7 +202,7 @@ def update( if agent_id not in self.data.agents: old_agent_retention = None self.data.agents[agent_id] = AgentConfig( - protected=agent_config.get("protected", False), + protected=agent_config.get("protected", True), retention=new_agent_retention, ) else: