Use subarray instead of slice

porsager · porsager · commit 088ab2f6a7d4 · 2022-07-03T00:30:28.000+02:00
diff --git a/src/bytes.js b/src/bytes.js
@@ -47,13 +47,13 @@ const b = Object.assign(reset, messages, {
     return b
   },
   raw(x) {
-    buffer = Buffer.concat([buffer.slice(0, b.i), x])
+    buffer = Buffer.concat([buffer.subarray(0, b.i), x])
     b.i = buffer.length
     return b
   },
   end(at = 1) {
     buffer.writeUInt32BE(b.i - at, at)
-    const out = buffer.slice(0, b.i)
+    const out = buffer.subarray(0, b.i)
     b.i = 0
     buffer = Buffer.allocUnsafe(size)
     return out
diff --git a/src/connection.js b/src/connection.js
@@ -309,12 +309,12 @@ function Connection(options, queues = {}, { onopen = noop, onend = noop, onclose
       }
 
       try {
-        handle(incoming.slice(0, length + 1))
+        handle(incoming.subarray(0, length + 1))
       } catch (e) {
         query && (query.cursorFn || query.describeFirst) && write(Sync)
         errored(e)
       }
-      incoming = incoming.slice(length + 1)
+      incoming = incoming.subarray(length + 1)
       remaining = 0
       incomings = null
     }
@@ -483,7 +483,7 @@ function Connection(options, queues = {}, { onopen = noop, onend = noop, onclose
       value = length === -1
         ? null
         : query.isRaw === true
-          ? x.slice(index, index += length)
+          ? x.subarray(index, index += length)
           : column.parser === undefined
             ? x.toString('utf8', index, index += length)
             : column.parser.array === true
@@ -652,7 +652,7 @@ function Connection(options, queues = {}, { onopen = noop, onend = noop, onclose
 
   async function AuthenticationMD5Password(x) {
     write(
-      b().p().str('md5' + md5(Buffer.concat([Buffer.from(md5((await Pass()) + user)), x.slice(9)]))).z(1).end()
+      b().p().str('md5' + md5(Buffer.concat([Buffer.from(md5((await Pass()) + user)), x.subarray(9)]))).z(1).end()
     )
   }
 
@@ -851,7 +851,7 @@ function Connection(options, queues = {}, { onopen = noop, onend = noop, onclose
   }
 
   function CopyData(x) {
-    stream.push(x.slice(5)) || socket.pause()
+    stream.push(x.subarray(5)) || socket.pause()
   }
 
   function CopyDone() {
diff --git a/src/subscribe.js b/src/subscribe.js
@@ -103,7 +103,7 @@ export default function Subscribe(postgres, options) {
 
     function data(x) {
       if (x[0] === 0x77)
-        parse(x.slice(25), state, sql.options.parsers, handle)
+        parse(x.subarray(25), state, sql.options.parsers, handle)
       else if (x[0] === 0x6b && x[17])
         pong()
     }
@@ -143,8 +143,8 @@ function parse(x, state, parsers, handle) {
     R: x => {  // Relation
       let i = 1
       const r = state[x.readUInt32BE(i)] = {
-        schema: String(x.slice(i += 4, i = x.indexOf(0, i))) || 'pg_catalog',
-        table: String(x.slice(i + 1, i = x.indexOf(0, i + 1))),
+        schema: String(x.subarray(i += 4, i = x.indexOf(0, i))) || 'pg_catalog',
+        table: String(x.subarray(i + 1, i = x.indexOf(0, i + 1))),
         columns: Array(x.readUInt16BE(i += 2)),
         keys: []
       }
@@ -156,7 +156,7 @@ function parse(x, state, parsers, handle) {
       while (i < x.length) {
         column = r.columns[columnIndex++] = {
           key: x[i++],
-          name: String(x.slice(i, i = x.indexOf(0, i))),
+          name: String(x.subarray(i, i = x.indexOf(0, i))),
           type: x.readUInt32BE(i += 1),
           parser: parsers[x.readUInt32BE(i)],
           atttypmod: x.readUInt32BE(i += 4)
@@ -170,7 +170,7 @@ function parse(x, state, parsers, handle) {
     O: () => { /* noop */ }, // Origin
     B: x => { // Begin
       state.date = Time(x.readBigInt64BE(9))
-      state.lsn = x.slice(1, 9)
+      state.lsn = x.subarray(1, 9)
     },
     I: x => { // Insert
       let i = 1

Original file line number	Diff line number	Diff line change
`@@ -309,12 +309,12 @@ function Connection(options, queues = {}, { onopen = noop, onend = noop, onclose`
`309`	`309`	`}`
`310`	`310`
`311`	`311`	`try {`
`312`		`- handle(incoming.slice(0, length + 1))`
	`312`	`+ handle(incoming.subarray(0, length + 1))`
`313`	`313`	`} catch (e) {`
`314`	`314`	`query && (query.cursorFn \|\| query.describeFirst) && write(Sync)`
`315`	`315`	`errored(e)`
`316`	`316`	`}`
`317`		`- incoming = incoming.slice(length + 1)`
	`317`	`+ incoming = incoming.subarray(length + 1)`
`318`	`318`	`remaining = 0`
`319`	`319`	`incomings = null`
`320`	`320`	`}`
`@@ -483,7 +483,7 @@ function Connection(options, queues = {}, { onopen = noop, onend = noop, onclose`
`483`	`483`	`value = length === -1`
`484`	`484`	`? null`
`485`	`485`	`: query.isRaw === true`
`486`		`- ? x.slice(index, index += length)`
	`486`	`+ ? x.subarray(index, index += length)`
`487`	`487`	`: column.parser === undefined`
`488`	`488`	`? x.toString('utf8', index, index += length)`
`489`	`489`	`: column.parser.array === true`
`@@ -652,7 +652,7 @@ function Connection(options, queues = {}, { onopen = noop, onend = noop, onclose`
`652`	`652`
`653`	`653`	`async function AuthenticationMD5Password(x) {`
`654`	`654`	`write(`
`655`		`- b().p().str('md5' + md5(Buffer.concat([Buffer.from(md5((await Pass()) + user)), x.slice(9)]))).z(1).end()`
	`655`	`+ b().p().str('md5' + md5(Buffer.concat([Buffer.from(md5((await Pass()) + user)), x.subarray(9)]))).z(1).end()`
`656`	`656`	`)`
`657`	`657`	`}`
`658`	`658`
`@@ -851,7 +851,7 @@ function Connection(options, queues = {}, { onopen = noop, onend = noop, onclose`
`851`	`851`	`}`
`852`	`852`
`853`	`853`	`function CopyData(x) {`
`854`		`- stream.push(x.slice(5)) \|\| socket.pause()`
	`854`	`+ stream.push(x.subarray(5)) \|\| socket.pause()`
`855`	`855`	`}`
`856`	`856`
`857`	`857`	`function CopyDone() {`