Don't gracefully handle unknown messages, just fail

porsager · porsager · commit ca82df9b524a · 2019-12-20T23:57:07.000+01:00
diff --git a/lib/connection.js b/lib/connection.js
@@ -161,7 +161,7 @@ function Connection(options = {}) {
       if (length >= buffer.length)
         break
 
-      (backend[buffer[0]] || unknown)(buffer.slice(0, length + 1))
+      backend[buffer[0]](buffer.slice(0, length + 1))
       buffer = buffer.slice(length + 1)
     }
   }
@@ -172,9 +172,8 @@ function Connection(options = {}) {
     ready = false
   }
 
-  function unknown() {
-    // console.log('Unknown Message', x[0])
-  }
+  /* c8 ignore next */
+  return connection
 }
 
 function postgresSocket(options, {

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ function Connection(options = {}) {`
`161`	`161`	`if (length >= buffer.length)`
`162`	`162`	`break`
`163`	`163`
`164`		`- (backend[buffer[0]] \|\| unknown)(buffer.slice(0, length + 1))`
	`164`	`+ backend[buffer[0]](buffer.slice(0, length + 1))`
`165`	`165`	`buffer = buffer.slice(length + 1)`
`166`	`166`	`}`
`167`	`167`	`}`
`@@ -172,9 +172,8 @@ function Connection(options = {}) {`
`172`	`172`	`ready = false`
`173`	`173`	`}`
`174`	`174`
`175`		`- function unknown() {`
`176`		`- // console.log('Unknown Message', x[0])`
`177`		`- }`
	`175`	`+ /* c8 ignore next */`
	`176`	`+ return connection`
`178`	`177`	`}`
`179`	`178`
`180`	`179`	`function postgresSocket(options, {`