Skip to content

Commit ebb2d09

Browse files
authored
fix: async audio only tests (videojs#7673)
1 parent 762e7bc commit ebb2d09

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/unit/player.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2809,11 +2809,13 @@ QUnit.test('playbackRates only accepts arrays of numbers', function(assert) {
28092809
QUnit.test('audioOnlyMode can be set by option', function(assert) {
28102810
assert.expect(4);
28112811

2812+
const done = assert.async();
28122813
const player = TestHelpers.makePlayer({audioOnlyMode: true});
28132814

28142815
player.one('audioonlymodechange', () => {
28152816
assert.equal(player.audioOnlyMode(), true, 'asynchronously set via option');
28162817
assert.equal(player.hasClass('vjs-audio-only-mode'), true, 'class added asynchronously');
2818+
done();
28172819
});
28182820

28192821
assert.equal(player.audioOnlyMode(), false, 'defaults to false');
@@ -2827,21 +2829,19 @@ QUnit.test('audioOnlyMode(true) returns Promise when promises are supported', fu
28272829
if (window.Promise) {
28282830
assert.ok(returnValTrue instanceof window.Promise, 'audioOnlyMode(true) returns Promise when supported');
28292831
}
2830-
2831-
return returnValTrue;
28322832
});
28332833

28342834
QUnit.test('audioOnlyMode(false) returns Promise when promises are supported', function(assert) {
2835+
const done = assert.async();
28352836
const player = TestHelpers.makePlayer({audioOnlyMode: true});
28362837

28372838
player.one('audioonlymodechange', () => {
28382839
const returnValFalse = player.audioOnlyMode(false);
28392840

28402841
if (window.Promise) {
28412842
assert.ok(returnValFalse instanceof window.Promise, 'audioOnlyMode(false) returns Promise when supported');
2843+
done();
28422844
}
2843-
2844-
return returnValFalse;
28452845
});
28462846
});
28472847

0 commit comments

Comments
 (0)