chore: Language versions update (optimizely#774)

shaharyar123 · web-flow · commit efe2f6c729a5 · 2022-08-14T20:51:33.000-07:00
## Summary Updated Minimum versions of the following **Typescript**: `4.7.4` **Node**: `14` **Browsers**: Chrome: `102.0` Edge: `84.0` Firefox: `91.0` Opera: `76.0` Safari: `13.0` ## Test plan All unit tests and Full stack compatibility suite tests pass. ## Ticket [OASIS-8467](https://optimizely.atlassian.net/browse/OASIS-8467)
diff --git a/.github/workflows/javascript.yml b/.github/workflows/javascript.yml
@@ -53,7 +53,7 @@ jobs:
     - name: Set up Node
       uses: actions/setup-node@v3
       with:
-        node-version: 12
+        node-version: 14
         cache: 'npm'
         cache-dependency-path: packages/optimizely-sdk/package-lock.json
     - name: Cross-browser and umd unit tests
@@ -66,7 +66,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [ '12', '14', '16', '18' ]
+        node: ['14', '16', '18' ]
     steps:
     - uses: actions/checkout@v3
     - name: Set up Node ${{ matrix.node }}
diff --git a/packages/datafile-manager/package-lock.json b/packages/datafile-manager/package-lock.json
diff --git a/packages/datafile-manager/package.json b/packages/datafile-manager/package.json
@@ -41,7 +41,7 @@
     "nock": "^10.0.6",
     "prettier": "^1.19.1",
     "ts-jest": "^27.0.1",
-    "typescript": "3.8.x"
+    "typescript": "^4.7.4"
   },
   "dependencies": {
     "@optimizely/js-sdk-logging": "^0.3.1",
diff --git a/packages/event-processor/__mocks__/@react-native-async-storage/async-storage.ts b/packages/event-processor/__mocks__/@react-native-async-storage/async-storage.ts
@@ -36,7 +36,7 @@ export default class AsyncStorage {
     return new Promise(resolve => {
       setTimeout(() => {
         items[key] && delete items[key]
-        resolve()
+        resolve(null)
       }, 1)
     })
   }
diff --git a/packages/event-processor/package.json b/packages/event-processor/package.json
@@ -48,7 +48,8 @@
     "jest": "^23.6.0",
     "jest-localstorage-mock": "^2.4.0",
     "ts-jest": "^23.10.5",
-    "typescript": "^4.0.3"
+    "typescript": "^4.7.4"
+
   },
   "peerDependencies": {
     "@react-native-community/netinfo": "5.9.4",
diff --git a/packages/event-processor/src/pendingEventsStore.ts b/packages/event-processor/src/pendingEventsStore.ts
@@ -75,7 +75,7 @@ export class LocalStorageStore<K extends StoreEntry> implements PendingEventsSto
       // This is a temporary fix to support React Native which does not have localStorage.
       window.localStorage && localStorage.setItem(this.LS_KEY, JSON.stringify(map))
       this.clean()
-    } catch (e) {
+    } catch (e: any) {
       logger.error(e)
     }
   }
@@ -109,7 +109,7 @@ export class LocalStorageStore<K extends StoreEntry> implements PendingEventsSto
       if (data) {
         return (JSON.parse(data) as { [key: string]: K }) || {}
       }
-    } catch (e) {
+    } catch (e: any) {
       logger.error(e)
     }
     return {}
diff --git a/packages/event-processor/src/v1/v1EventProcessor.react_native.ts b/packages/event-processor/src/v1/v1EventProcessor.react_native.ts
@@ -228,8 +228,8 @@ export class LogTierV1EventProcessor implements EventProcessor {
       this.unsubscribeNetInfo && this.unsubscribeNetInfo()
       await this.queue.stop()
       return this.requestTracker.onRequestsComplete()
-    } catch (e) {
-      logger.error('Error stopping EventProcessor: "%s"', e.message, e)
+    } catch (e: any) {
+      logger.error('Error stopping EventProcessor: "%s"', e?.message, e)
     }
   }
 }
diff --git a/packages/event-processor/src/v1/v1EventProcessor.ts b/packages/event-processor/src/v1/v1EventProcessor.ts
@@ -88,7 +88,7 @@ export class LogTierV1EventProcessor implements EventProcessor {
     try {
       this.queue.stop()
       return this.requestTracker.onRequestsComplete()
-    } catch (e) {
+    } catch (e: any) {
       logger.error('Error stopping EventProcessor: "%s"', e.message, e)
     }
     return Promise.resolve()
diff --git a/packages/logging/package-lock.json b/packages/logging/package-lock.json
diff --git a/packages/logging/package.json b/packages/logging/package.json
@@ -43,6 +43,6 @@
     "@types/jest": "^23.3.12",
     "jest": "^23.6.0",
     "ts-jest": "^23.10.5",
-    "typescript": "3.8.x"
+    "typescript": "^4.7.4"
   }
 }
diff --git a/packages/optimizely-sdk/.eslintrc.js b/packages/optimizely-sdk/.eslintrc.js
@@ -31,6 +31,5 @@ module.exports = {
     'no-prototype-builtins': 'off',
     '@typescript-eslint/explicit-module-boundary-types': 'off',
     '@typescript-eslint/no-empty-function': 'off',
-    'no-shadow': 'error',
   },
 };
diff --git a/packages/optimizely-sdk/CHANGELOG.md b/packages/optimizely-sdk/CHANGELOG.md
@@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
-### Changed
+### Breaking Changes
 - Updated `murmurhash` dependency to version `2.0.1`.
 - Updated `uuid` dependency to version `8.3.2`.
 - Dropped support for the following browser versions.
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
   - Firefox versions earlier than `91.0`.
   - Opera versions earlier than `76.0`.
   - Safari versions earlier than `13.0`.
+- Dropped support for Node JS versions earlier than `14`.
 
 ## [4.9.2] - June 27, 2022
 
diff --git a/packages/optimizely-sdk/lib/core/audience_evaluator/index.ts b/packages/optimizely-sdk/lib/core/audience_evaluator/index.ts
@@ -109,7 +109,7 @@ export class AudienceEvaluator {
     }
     try {
       return evaluator.evaluate(condition, user);
-    } catch (err) {
+    } catch (err: any) {
       logger.log(
         LOG_LEVEL.ERROR,
         ERROR_MESSAGES.CONDITION_EVALUATOR_ERROR, MODULE_NAME, condition.type, err.message
diff --git a/packages/optimizely-sdk/lib/core/bucketer/index.ts b/packages/optimizely-sdk/lib/core/bucketer/index.ts
@@ -234,7 +234,7 @@ export const _generateBucketValue = function(bucketingKey: string): number {
     const hashValue = murmurhash.v3(bucketingKey, HASH_SEED);
     const ratio = hashValue / MAX_HASH_VALUE;
     return Math.floor(ratio * MAX_TRAFFIC_VALUE);
-  } catch (ex) {
+  } catch (ex: any) {
     throw new Error(sprintf(ERROR_MESSAGES.INVALID_BUCKETING_ID, MODULE_NAME, bucketingKey, ex.message));
   }
 };
diff --git a/packages/optimizely-sdk/lib/core/decision_service/index.ts b/packages/optimizely-sdk/lib/core/decision_service/index.ts
@@ -484,7 +484,7 @@ export class DecisionService {
 
     try {
       return this.userProfileService.lookup(userId);
-    } catch (ex) {
+    } catch (ex: any) {
       this.logger.log(
         LOG_LEVEL.ERROR,
         ERROR_MESSAGES.USER_PROFILE_LOOKUP_ERROR,
@@ -532,7 +532,7 @@ export class DecisionService {
         experiment.key,
         userId,
       );
-    } catch (ex) {
+    } catch (ex: any) {
       this.logger.log(LOG_LEVEL.ERROR, ERROR_MESSAGES.USER_PROFILE_SAVE_ERROR, MODULE_NAME, userId, ex.message);
     }
   }
@@ -972,7 +972,7 @@ export class DecisionService {
           reasons: decideReasons,
         };
       }
-    } catch (ex) {
+    } catch (ex: any) {
       // catching experiment not in datafile
       this.logger.log(LOG_LEVEL.ERROR, ex.message);
       decideReasons.push(ex.message);
@@ -1065,7 +1065,7 @@ export class DecisionService {
         );
         return false;
       }
-    } catch (ex) {
+    } catch (ex: any) {
       // catching experiment not in datafile
       this.logger.log(LOG_LEVEL.ERROR, ex.message);
       return false;
@@ -1075,7 +1075,7 @@ export class DecisionService {
       try {
         this.removeForcedVariation(userId, experimentId, experimentKey);
         return true;
-      } catch (ex) {
+      } catch (ex: any) {
         this.logger.log(LOG_LEVEL.ERROR, ex.message);
         return false;
       }
@@ -1097,7 +1097,7 @@ export class DecisionService {
     try {
       this.setInForcedVariationMap(userId, experimentId, variationId);
       return true;
-    } catch (ex) {
+    } catch (ex: any) {
       this.logger.log(LOG_LEVEL.ERROR, ex.message);
       return false;
     }
diff --git a/packages/optimizely-sdk/lib/core/notification_center/index.ts b/packages/optimizely-sdk/lib/core/notification_center/index.ts
@@ -116,7 +116,7 @@ export class NotificationCenter {
       const returnId = this.listenerId;
       this.listenerId += 1;
       return returnId;
-    } catch (e) {
+    } catch (e: any) {
       this.logger.log(LOG_LEVEL.ERROR, e.message);
       this.errorHandler.handleError(e);
       return -1;
@@ -159,7 +159,7 @@ export class NotificationCenter {
         this.notificationListeners[typeToRemove].splice(indexToRemove, 1);
         return true;
       }
-    } catch (e) {
+    } catch (e: any) {
       this.logger.log(LOG_LEVEL.ERROR, e.message);
       this.errorHandler.handleError(e);
     }
@@ -177,7 +177,7 @@ export class NotificationCenter {
           this.notificationListeners[notificationTypeEnum] = [];
         }
       );
-    } catch (e) {
+    } catch (e: any) {
       this.logger.log(LOG_LEVEL.ERROR, e.message);
       this.errorHandler.handleError(e);
     }
@@ -190,7 +190,7 @@ export class NotificationCenter {
   clearNotificationListeners(notificationType: NOTIFICATION_TYPES): void {
     try {
       this.notificationListeners[notificationType] = [];
-    } catch (e) {
+    } catch (e: any) {
       this.logger.log(LOG_LEVEL.ERROR, e.message);
       this.errorHandler.handleError(e);
     }
@@ -212,7 +212,7 @@ export class NotificationCenter {
           const callback = listenerEntry.callback;
           try {
             callback(notificationData);
-          } catch (ex) {
+          } catch (ex: any) {
             this.logger.log(
               LOG_LEVEL.ERROR,
               LOG_MESSAGES.NOTIFICATION_LISTENER_EXCEPTION,
@@ -223,7 +223,7 @@ export class NotificationCenter {
           }
         }
       );
-    } catch (e) {
+    } catch (e: any) {
       this.logger.log(LOG_LEVEL.ERROR, e.message);
       this.errorHandler.handleError(e);
     }
diff --git a/packages/optimizely-sdk/lib/core/project_config/index.ts b/packages/optimizely-sdk/lib/core/project_config/index.ts
@@ -759,7 +759,7 @@ export const getTypeCastValue = function (
     case FEATURE_VARIABLE_TYPES.JSON:
       try {
         castValue = JSON.parse(variableValue);
-      } catch (e) {
+      } catch (e: any) {
         logger.log(
           LOG_LEVEL.ERROR,
           ERROR_MESSAGES.UNABLE_TO_CAST_VALUE,
@@ -843,15 +843,15 @@ export const tryCreatingProjectConfig = function (
   let newDatafileObj;
   try {
     newDatafileObj = configValidator.validateDatafile(config.datafile);
-  } catch (error) {
+  } catch (error: any) {
     return { configObj: null, error };
   }
 
   if (config.jsonSchemaValidator) {
     try {
       config.jsonSchemaValidator.validate(newDatafileObj);
       config.logger.log(LOG_LEVEL.INFO, LOG_MESSAGES.VALID_DATAFILE, MODULE_NAME);
-    } catch (error) {
+    } catch (error : any) {
       return { configObj: null, error };
     }
   } else {
diff --git a/packages/optimizely-sdk/lib/core/project_config/project_config_manager.ts b/packages/optimizely-sdk/lib/core/project_config/project_config_manager.ts
@@ -105,7 +105,7 @@ export class ProjectConfigManager {
           reason: getErrorMessage(handleNewDatafileException, 'Invalid datafile'),
         });
       }
-    } catch (ex) {
+    } catch (ex: any) {
       logger.error(ex);
       this.readyPromise = Promise.resolve({
         success: false,
diff --git a/packages/optimizely-sdk/lib/index.browser.ts b/packages/optimizely-sdk/lib/index.browser.ts
@@ -70,7 +70,7 @@ const createInstance = function(config: Config): Client | null {
     try {
       configValidator.validate(config);
       isValidInstance = true;
-    } catch (ex) {
+    } catch (ex: any) {
       logger.error(ex);
     }
 
@@ -141,12 +141,12 @@ const createInstance = function(config: Config): Client | null {
           false
         );
       }
-    } catch (e) {
+    } catch (e: any) {
       logger.error(enums.LOG_MESSAGES.UNABLE_TO_ATTACH_UNLOAD, MODULE_NAME, e.message);
     }
 
     return optimizely;
-  } catch (e) {
+  } catch (e: any) {
     logger.error(e);
     return null;
   }
diff --git a/packages/optimizely-sdk/lib/index.lite.ts b/packages/optimizely-sdk/lib/index.lite.ts
@@ -63,7 +63,7 @@ setLogLevel(LogLevel.ERROR);
     try {
       configValidator.validate(config);
       isValidInstance = true;
-    } catch (ex) {
+    } catch (ex: any) {
       logger.error(ex);
     }
 
@@ -85,7 +85,7 @@ setLogLevel(LogLevel.ERROR);
 
     const optimizely = new Optimizely(optimizelyOptions);
     return optimizely;
-  } catch (e) {
+  } catch (e: any) {
     logger.error(e);
     return null;
   }
diff --git a/packages/optimizely-sdk/lib/index.node.ts b/packages/optimizely-sdk/lib/index.node.ts
@@ -68,7 +68,7 @@ const DEFAULT_EVENT_MAX_QUEUE_SIZE = 10000;
     try {
       configValidator.validate(config);
       isValidInstance = true;
-    } catch (ex) {
+    } catch (ex: any) {
       if (hasLogger) {
         logger.error(ex);
       } else {
@@ -117,7 +117,7 @@ const DEFAULT_EVENT_MAX_QUEUE_SIZE = 10000;
     };
 
     return new Optimizely(optimizelyOptions);
-  } catch (e) {
+  } catch (e: any) {
     logger.error(e);
     return null;
   }
diff --git a/packages/optimizely-sdk/lib/index.react_native.ts b/packages/optimizely-sdk/lib/index.react_native.ts
@@ -67,7 +67,7 @@ const DEFAULT_EVENT_MAX_QUEUE_SIZE = 10000;
     try {
       configValidator.validate(config);
       isValidInstance = true;
-    } catch (ex) {
+    } catch (ex: any) {
       logger.error(ex);
     }
 
@@ -117,7 +117,7 @@ const DEFAULT_EVENT_MAX_QUEUE_SIZE = 10000;
     }
 
     return new Optimizely(optimizelyOptions);
-  } catch (e) {
+  } catch (e: any) {
     logger.error(e);
     return null;
   }
diff --git a/packages/optimizely-sdk/lib/optimizely/index.ts b/packages/optimizely-sdk/lib/optimizely/index.ts
diff --git a/packages/optimizely-sdk/package-lock.json b/packages/optimizely-sdk/package-lock.json
diff --git a/packages/optimizely-sdk/package.json b/packages/optimizely-sdk/package.json
diff --git a/packages/utils/package-lock.json b/packages/utils/package-lock.json
diff --git a/packages/utils/package.json b/packages/utils/package.json

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ export default class AsyncStorage {`
`36`	`36`	`return new Promise(resolve => {`
`37`	`37`	`setTimeout(() => {`
`38`	`38`	`items[key] && delete items[key]`
`39`		`- resolve()`
	`39`	`+ resolve(null)`
`40`	`40`	`}, 1)`
`41`	`41`	`})`
`42`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ export class LocalStorageStore<K extends StoreEntry> implements PendingEventsSto`
`75`	`75`	`// This is a temporary fix to support React Native which does not have localStorage.`
`76`	`76`	`window.localStorage && localStorage.setItem(this.LS_KEY, JSON.stringify(map))`
`77`	`77`	`this.clean()`
`78`		`- } catch (e) {`
	`78`	`+ } catch (e: any) {`
`79`	`79`	`logger.error(e)`
`80`	`80`	`}`
`81`	`81`	`}`
`@@ -109,7 +109,7 @@ export class LocalStorageStore<K extends StoreEntry> implements PendingEventsSto`
`109`	`109`	`if (data) {`
`110`	`110`	`return (JSON.parse(data) as { [key: string]: K }) \|\| {}`
`111`	`111`	`}`
`112`		`- } catch (e) {`
	`112`	`+ } catch (e: any) {`
`113`	`113`	`logger.error(e)`
`114`	`114`	`}`
`115`	`115`	`return {}`
Original file line number	Diff line number	Diff line change
`@@ -228,8 +228,8 @@ export class LogTierV1EventProcessor implements EventProcessor {`
`228`	`228`	`this.unsubscribeNetInfo && this.unsubscribeNetInfo()`
`229`	`229`	`await this.queue.stop()`
`230`	`230`	`return this.requestTracker.onRequestsComplete()`
`231`		`- } catch (e) {`
`232`		`- logger.error('Error stopping EventProcessor: "%s"', e.message, e)`
	`231`	`+ } catch (e: any) {`
	`232`	`+ logger.error('Error stopping EventProcessor: "%s"', e?.message, e)`
`233`	`233`	`}`
`234`	`234`	`}`
`235`	`235`	`}`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ export class LogTierV1EventProcessor implements EventProcessor {`
`88`	`88`	`try {`
`89`	`89`	`this.queue.stop()`
`90`	`90`	`return this.requestTracker.onRequestsComplete()`
`91`		`- } catch (e) {`
	`91`	`+ } catch (e: any) {`
`92`	`92`	`logger.error('Error stopping EventProcessor: "%s"', e.message, e)`
`93`	`93`	`}`
`94`	`94`	`return Promise.resolve()`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,6 @@`
`43`	`43`	`"@types/jest": "^23.3.12",`
`44`	`44`	`"jest": "^23.6.0",`
`45`	`45`	`"ts-jest": "^23.10.5",`
`46`		`- "typescript": "3.8.x"`
	`46`	`+ "typescript": "^4.7.4"`
`47`	`47`	`}`
`48`	`48`	`}`