Skip to content

Commit ba46199

Browse files
committed
Revert "linux: disable crash reporting in CI (microsoft#142572)"
This reverts commit 7dbd736.
1 parent 4b93608 commit ba46199

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

test-integration.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ else
88
ROOT=$(dirname $(dirname $(readlink -f $0)))
99
# --disable-dev-shm-usage --use-gl=swiftshader: when run on docker containers where size of /dev/shm
1010
# partition < 64MB which causes OOM failure for chromium compositor that uses the partition for shared memory
11-
# --disable-crash-reporter: TODO@electron this needs Electron 17 to work (https://github.com/microsoft/vscode/issues/142572)
12-
LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader --disable-crash-reporter"
11+
LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader"
1312
fi
1413

1514
VSCODEUSERDATADIR=`mktemp -d 2>/dev/null`

test-remote-integration.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ else
88
ROOT=$(dirname $(dirname $(readlink -f $0)))
99
# --disable-dev-shm-usage --use-gl=swiftshader: when run on docker containers where size of /dev/shm
1010
# partition < 64MB which causes OOM failure for chromium compositor that uses the partition for shared memory
11-
# --disable-crash-reporter: TODO@electron this needs Electron 17 to work (https://github.com/microsoft/vscode/issues/142572)
12-
LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader --disable-crash-reporter"
11+
LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader"
1312
fi
1413

1514
VSCODEUSERDATADIR=`mktemp -d 2>/dev/null`

test.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ else
88
ROOT=$(dirname $(dirname $(readlink -f $0)))
99
# --disable-dev-shm-usage --use-gl=swiftshader: when run on docker containers where size of /dev/shm
1010
# partition < 64MB which causes OOM failure for chromium compositor that uses the partition for shared memory
11-
# --disableCrashReporter: TODO@electron this needs Electron 17 to work (https://github.com/microsoft/vscode/issues/142572)
12-
LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader --disableCrashReporter"
11+
LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader"
1312
fi
1413

1514
cd $ROOT

0 commit comments

Comments
 (0)