feat: don't warn about multiple Vue instances when testing in JSDOM (closes bootstrap-vue#3303) (bootstrap-vue#3315)

tmorehouse · web-flow · commit 0caa29b836f4 · 2019-05-16T17:31:25.000-03:00
diff --git a/src/components/modal/helpers/bv-modal.spec.js b/src/components/modal/helpers/bv-modal.spec.js
@@ -6,16 +6,9 @@ describe('$bvModal', () => {
   const localVue = new CreateLocalVue()
 
   beforeAll(() => {
-    // Prevent multiple Vue warnings in tests
-    jest.spyOn(console, 'warn').mockImplementation(() => {})
-    // Install plugin after we have trapped console.warn
     localVue.use(modalPlugin)
   })
 
-  afterAll(() => {
-    console.warn.mockClear()
-  })
-
   it('$bvModal.show() and $bvModal.hide() works', async () => {
     const App = localVue.extend({
       render(h) {
diff --git a/src/components/toast/helpers/bv-toast.spec.js b/src/components/toast/helpers/bv-toast.spec.js
@@ -6,16 +6,9 @@ describe('$bvToast', () => {
   const localVue = new CreateLocalVue()
 
   beforeAll(() => {
-    // Prevent multiple Vue warnings in tests
-    jest.spyOn(console, 'warn').mockImplementation(() => {})
-    // Install plugin after we have trapped console.warn
     localVue.use(toastPlugin)
   })
 
-  afterAll(() => {
-    console.warn.mockClear()
-  })
-
   it('$bvToast.show() and $bvToast.hide() works', async () => {
     const App = localVue.extend({
       render(h) {
diff --git a/src/utils/config.spec.js b/src/utils/config.spec.js
@@ -16,13 +16,7 @@ import AlertPlugin from '../../src/components/alert'
 import BVConfigPlugin from '../../src/bv-config'
 
 describe('utils/config', () => {
-  beforeEach(() => {
-    // Prevent multiple Vue warnings in tests
-    jest.spyOn(console, 'warn').mockImplementation(() => {})
-  })
-
   afterEach(() => {
-    console.warn.mockClear()
     resetConfig()
   })
 
diff --git a/src/utils/dom.js b/src/utils/dom.js
@@ -55,11 +55,13 @@ export const MutationObs =
 // Normalize event options based on support of passive option
 // Exported only for testing purposes
 export const parseEventOptions = options => {
-  if (!hasPassiveEventSupport) {
+  /* istanbul ignore else: can't test in JSDOM, as it supports passive */
+  if (hasPassiveEventSupport) {
+    return isObject(options) ? options : { useCapture: Boolean(options || false) }
+  } else {
     // Need to translate to actual Boolean value
     return Boolean(isObject(options) ? options.useCapture : options)
   }
-  return isObject(options) ? options : { useCapture: Boolean(options || false) }
 }
 
 // Attach an event listener to an element
diff --git a/src/utils/env.js b/src/utils/env.js
@@ -15,6 +15,8 @@ export const hasMutationObserverSupport =
 
 export const isBrowser = hasWindowSupport && hasDocumentSupport && hasNavigatorSupport
 
+export const isJSDOM = isBrowser && navigator.userAgent.includes('jsdom')
+
 // Determine if the browser supports the option passive for events
 export const hasPassiveEventSupport = (() => {
   let passiveEventSupported = false
diff --git a/src/utils/plugins.js b/src/utils/plugins.js
@@ -1,7 +1,7 @@
 import OurVue from './vue'
 import warn from './warn'
 import { setConfig } from './config'
-import { hasWindowSupport } from './env'
+import { hasWindowSupport, isJSDOM } from './env'
 
 const MULTIPLE_VUE_WARNING = `Multiple instances of Vue detected!
 See: https://bootstrap-vue.js.org/docs#using-module-bundlers`
@@ -14,7 +14,7 @@ let checkMultipleVueWarned = false
  */
 export const checkMultipleVue = Vue => {
   /* istanbul ignore next */
-  if (!checkMultipleVueWarned && OurVue !== Vue) {
+  if (!checkMultipleVueWarned && OurVue !== Vue && !isJSDOM) {
     warn(MULTIPLE_VUE_WARNING)
     checkMultipleVueWarned = true
   }
