Merge pull request coderwall#285 from avinoth/master

seuros · seuros · commit d24d28a40e04 · 2015-01-08T19:14:13.000Z
clean up endorsements with no valid skills
diff --git a/app/models/skill.rb b/app/models/skill.rb
@@ -5,7 +5,7 @@ class Skill < ActiveRecord::Base
   BLANK = ''
 
   belongs_to :user
-  has_many :endorsements
+  has_many :endorsements, dependent: :delete_all
 
   validates_presence_of :tokenized
   validates_presence_of :user_id
diff --git a/db/migrate/20150108152023_cleanup_endorsements_without_skill.rb b/db/migrate/20150108152023_cleanup_endorsements_without_skill.rb
@@ -0,0 +1,9 @@
+class CleanupEndorsementsWithoutSkill < ActiveRecord::Migration
+  def up
+    Endorsement.delete_all(skill_id: [nil,''])
+  end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
@@ -11,7 +11,7 @@
 #
 # It's strongly recommended to check this file into your version control system.
 
-ActiveRecord::Schema.define(:version => 20150103105333) do
+ActiveRecord::Schema.define(:version => 20150108152023) do
 
   add_extension "citext"
   add_extension "hstore"

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`#`
`12`	`12`	`# It's strongly recommended to check this file into your version control system.`
`13`	`13`
`14`		`-ActiveRecord::Schema.define(:version => 20150103105333) do`
	`14`	`+ActiveRecord::Schema.define(:version => 20150108152023) do`
`15`	`15`
`16`	`16`	`add_extension "citext"`
`17`	`17`	`add_extension "hstore"`