clean up event bindings

Dave Newman · Dave Newman · commit 41488b78442c · 2016-06-08T11:58:47.000-07:00
diff --git a/app/assets/javascripts/components/Chat.es6.jsx b/app/assets/javascripts/components/Chat.es6.jsx
@@ -176,6 +176,8 @@ class Chat extends React.Component {
 
   componentWillUnmount() {
     $(this.refs.scrollable).unbind('mousewheel DOMMouseScroll')
+    $(window).off('video-resize')
+    $(window).off('video-time')
   }
 
   componentWillUpdate() {
diff --git a/app/assets/javascripts/components/Video.es6.jsx b/app/assets/javascripts/components/Video.es6.jsx
@@ -34,6 +34,10 @@ class Video extends React.Component {
     // this.jwplayer.on('all', this.onAll.bind(this))
   }
 
+  componentWillUnmount() {
+    this.jwplayer.remove()
+  }
+
   render() {
     return (
       <div>

Original file line number	Diff line number	Diff line change
`@@ -176,6 +176,8 @@ class Chat extends React.Component {`
`176`	`176`
`177`	`177`	`componentWillUnmount() {`
`178`	`178`	`$(this.refs.scrollable).unbind('mousewheel DOMMouseScroll')`
	`179`	`+ $(window).off('video-resize')`
	`180`	`+ $(window).off('video-time')`
`179`	`181`	`}`
`180`	`182`
`181`	`183`	`componentWillUpdate() {`