fixing issue where public_id is lost on porting

mdeiters · mdeiters · commit ec42a5309b20 · 2016-02-19T15:38:50.000-08:00
diff --git a/app/models/protip.rb b/app/models/protip.rb
@@ -19,7 +19,9 @@ class Protip < ActiveRecord::Base
 
   scope :random, ->(count=1) { order("RANDOM()").limit(count) }
   scope :recently_created, ->(count=5) { order(created_at: :desc).limit(count)}
-  scope :recently_most_viewed, ->{ order(views_count: :desc).where(public_id: %w{ewk0mq kvzbpa vsdrug os6woq w7npmq _kakfa}) }
+  scope :recently_most_viewed, ->{ order(views_count: :desc).where(
+    public_id: %w{ewk0mq kvzbpa vsdrug os6woq w7npmq _kakfa})
+  }
 
   def to_param
     self.public_id
@@ -81,6 +83,7 @@ def cacluate_score
   end
 
   def generate_public_id
+    return self.public_id if self.public_id
     self.public_id = SecureRandom.urlsafe_base64(4).downcase
     #retry if not unique
     generate_public_id unless Protip.where(public_id: self.public_id).blank?
