diff --git a/lib/cc/engine/analyzers/javascript/minification_checker.rb b/lib/cc/engine/analyzers/javascript/minification_checker.rb index e241374b..7ede7ab5 100644 --- a/lib/cc/engine/analyzers/javascript/minification_checker.rb +++ b/lib/cc/engine/analyzers/javascript/minification_checker.rb @@ -10,8 +10,12 @@ def initialize(path) end def minified? - ratio = content.chars.count / content.lines.count - ratio >= MINIFIED_AVG_LINE_LENGTH_CUTOFF + if content.lines.count.nonzero? + ratio = content.chars.count / content.lines.count + ratio >= MINIFIED_AVG_LINE_LENGTH_CUTOFF + else + false + end end private diff --git a/spec/cc/engine/analyzers/javascript/minification_checker_spec.rb b/spec/cc/engine/analyzers/javascript/minification_checker_spec.rb index 4a27a03a..2d338e4f 100644 --- a/spec/cc/engine/analyzers/javascript/minification_checker_spec.rb +++ b/spec/cc/engine/analyzers/javascript/minification_checker_spec.rb @@ -18,6 +18,11 @@ module Javascript path = fixture_path("normal_js_file.js") expect(MinificationChecker.new(path)).to_not be_minified end + + it "returns false for empty files" do + path = fixture_path("empty_file.js") + expect(MinificationChecker.new(path)).to_not be_minified + end end end end diff --git a/spec/fixtures/empty_file.js b/spec/fixtures/empty_file.js new file mode 100644 index 00000000..e69de29b