Skip to content

Ignore settings for plugins that aren't supported #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gilbarbara opened this issue Aug 16, 2017 · 15 comments
Closed

Ignore settings for plugins that aren't supported #320

gilbarbara opened this issue Aug 16, 2017 · 15 comments

Comments

@gilbarbara
Copy link
Contributor

gilbarbara commented Aug 16, 2017 •
edited
Loading

Hello,

Since eslint-plugin-import can't be used with CodeClimate, is there a way to ignore its settings? This engine breaks with Error: unable to load resolver "webpack". with the configuration below.

"settings": {
    "import/resolver": {
      "webpack": {
        "config": "./config/webpack.config.js"
      }
    }
  }
@maxjacobson maxjacobson assigned gdiggs and unassigned maxjacobson Aug 16, 2017
@abbyarmada
Copy link
Contributor

@katwchen do you mind taking a look at this and actioning a fix? We've had past discussions about it before https://github.com/codeclimate/codeclimate-eslint/search?q=webpack&type=Issues&utf8=%E2%9C%93

@gusano
Copy link

gusano commented Sep 19, 2017

any update on that?

@gilbarbara
Copy link
Contributor Author

Hey guys, any news here?
I'm unable to use CodeClimate since all my builds are broken because of this.
Is it fixable? @abbyarmada @katwchen

@abbyarmada
Copy link
Contributor

Hey @gilbarbara, I just pinged someone about this and we're looking into it. Thanks for your patience!

@gdiggs
Copy link
Contributor

gdiggs commented Oct 13, 2017

Hey @gilbarbara I just shipped something that I think will address this! I tested it on a few of your OSS repos. Can you try another build and let me know what your experience is like?

@gilbarbara
Copy link
Contributor Author

hey @gordondiggs
I still got the error on codeclimate site. Is it in production yet or just the cli?

Ignoring the following rules that rely on module resolution:

* import/extensions
* import/no-unresolved
* import/no-extraneous-dependencies
* import/no-absolute-path
* import/no-duplicates
* import/no-named-as-default-member
module.js:471
    throw err;
    ^

Error: Cannot find module 'webpack'
...

@gdiggs
Copy link
Contributor

gdiggs commented Oct 16, 2017

@gilbarbara can you email me a link to where you see that? gordon[at]codeclimate[dot]com

@gilbarbara
Copy link
Contributor Author

@gordondiggs Did you get my email? Anything else I could do?

@gilbarbara
Copy link
Contributor Author

gilbarbara commented Oct 30, 2017 •
edited
Loading

@gordondiggs
Just to let you know the analysis worked in the CLI (0.6.8).

edit: maybe it worked because I have the node_modules locally. 😐

@gilbarbara
Copy link
Contributor Author

@abbyarmada
I'm getting pressured to cancel my organization subscription as we aren't getting proper reports since July. 😞

@gdiggs
Copy link
Contributor

gdiggs commented Nov 6, 2017

@gilbarbara I didn't realize you are on the eslint-4 channel. Let me port the changes there!

@gdiggs gdiggs mentioned this issue Nov 6, 2017
Closed
gdiggs added a commit that referenced this issue Nov 6, 2017
@gdiggs
Add more packages and blocklist more rules
44a35a7 
Ports #342 to the eslint-4 channel

Addresses #320
@gdiggs gdiggs mentioned this issue Nov 6, 2017
Merged
gdiggs added a commit that referenced this issue Nov 6, 2017
@gdiggs
Add more packages and blocklist more rules (#350)
f625f5f 
* Find parent eslint package

There may be another package that depends on eslint, and in that case,
we get multiple versions in the output here

* Add more packages and blocklist more rules

Ports #342 to the eslint-4 channel

Addresses #320
@gilbarbara
Copy link
Contributor Author

@gordondiggs Are these changes already on codeclimate.com runner?

@gdiggs
Copy link
Contributor

gdiggs commented Nov 16, 2017

@gilbarbara they are! If you're still having trouble, I would suggest removing the parts of your config that use the resolver stuff, as it is not supported on Code Climate right now

@gilbarbara
Copy link
Contributor Author

humm, ok.

Can you say what's working and what's not?
I'll try to turn off some stuff but still...

@gdiggs gdiggs removed their assignment Nov 22, 2017
@gilbarbara
Copy link
Contributor Author

Hey,
I finally got the time to debug this and for my setup, the culprit was the import/export rule.
Despite having import/export enabled flag set to false in my .codeclimate.yml, the engine still breaks. When I turn it off directly in my .eslintrc the error was gone...

Funny thing is I have the same config for more than 10 projects and this was the only one having problems. ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gilbarbara @gdiggs @gusano @maxjacobson @abbyarmada