fixed bug with 'defined?' being mistakenly used instad of 'const_defined?' which caused the defined to always return truthy becuase defined returned a string; irony alert: added missing test coverage

peppyheppy · peppyheppy · commit bde1ad2c45d9 · 2015-02-19T23:07:41.000-08:00
diff --git a/lib/code_climate/test_reporter/git.rb b/lib/code_climate/test_reporter/git.rb
@@ -58,7 +58,7 @@ def configured_git_dir
         end
 
         def rails_git_dir_present?
-          defined?(Rails) && !Rails.root.nil? &&
+          const_defined?(:Rails) && Rails.respond_to?(:root) && !Rails.root.nil? &&
             File.directory?(File.expand_path('.git', Rails.root))
         end
       end
diff --git a/spec/lib/git_spec.rb b/spec/lib/git_spec.rb
@@ -22,7 +22,40 @@ module CodeClimate::TestReporter
         expect(Git).to receive(:`).once.with "git --git-dir=\"#{path}/.git\" help"
 
         Git.send :git, 'help'
+      end
+
+      context 'ensure logic that replies on Rails is robust in non-rails environments' do
+        before :all do
+          module ::Rails; end
+        end
+
+        after :all do
+          Object.send(:remove_const, :Rails)
         end
+
+        after :each do
+          Git.send :git, 'help'
+        end
+
+        it 'will check if constant Rails is defined' do
+          expect(Git).to receive(:configured_git_dir).once.and_return(nil)
+        end
+
+        it 'will not rails root if constant Rails is defined but does not respond to root' do
+          expect(Git).to receive(:configured_git_dir).once.and_return(nil)
+          expect(Rails).to receive(:root).twice.and_return('/path')
+        end
+
+        it 'will call rails root if constant Rails is defined and root method is defined' do
+          module ::Rails
+            def self.root
+              '/path'
+            end
+          end
+          expect(Git).to receive(:configured_git_dir).once.and_return(nil)
+          expect(Rails).to receive(:root).twice.and_return('/path')
+        end
+      end
     end
 
     describe 'branch_from_git_or_ci' do
