From 37118816be5cca560bfd79efffe7a2754b44c4b1 Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Mon, 12 Sep 2022 15:53:23 -0400 Subject: [PATCH 1/2] fix: add divide by 0 use case --- app/test_calculator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test_calculator.py b/app/test_calculator.py index 43bc650e..62a63906 100644 --- a/app/test_calculator.py +++ b/app/test_calculator.py @@ -28,4 +28,4 @@ def test_divide(): assert Calculator.divide(1.0, 2.0) == 0.5 assert Calculator.divide(0, 2.0) == 0 assert Calculator.divide(-4, 2.0) == -2.0 - # assert Calculator.divide(2.0, 0.0) == 'Cannot divide by 0' + assert Calculator.divide(2.0, 0.0) == 'Cannot divide by 0' From 4f9ca5fb408d805eae891f1959bee2c7850fa0cc Mon Sep 17 00:00:00 2001 From: Tom Hu Date: Mon, 12 Sep 2022 16:03:42 -0400 Subject: [PATCH 2/2] fix: divide is deprecated --- app/test_calculator.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/app/test_calculator.py b/app/test_calculator.py index 62a63906..3a284ff8 100644 --- a/app/test_calculator.py +++ b/app/test_calculator.py @@ -22,10 +22,3 @@ def test_multiply(): assert Calculator.multiply(0, 2.0) == 0.0 assert Calculator.multiply(2.0, 0.0) == 0.0 assert Calculator.multiply(-4, 2.0) == -8.0 - -def test_divide(): - assert Calculator.divide(1, 2) == 0.5 - assert Calculator.divide(1.0, 2.0) == 0.5 - assert Calculator.divide(0, 2.0) == 0 - assert Calculator.divide(-4, 2.0) == -2.0 - assert Calculator.divide(2.0, 0.0) == 'Cannot divide by 0'