BUG26847553: Fix AttributeError when using pure Python Protobuf

nmariz · nmariz · commit a166f491b911 · 2017-09-22T18:08:41.000+01:00
Using a value of type list when setting an attribute in a Message object
throws an AttributeError.

This patch fix this issue by testing the value type and using the .extend()
method for list type values.

This patch also adds the encoding of string values types to bytes when using
Python 3.
diff --git a/lib/mysqlx/protobuf/__init__.py b/lib/mysqlx/protobuf/__init__.py
@@ -24,7 +24,8 @@
 """This module contains the implementation of a helper class for MySQL X
 Protobuf messages."""
 
-from mysqlx.compat import NUMERIC_TYPES, STRING_TYPES, BYTE_TYPES
+from mysqlx.compat import PY3, NUMERIC_TYPES, STRING_TYPES, BYTE_TYPES
+from mysqlx.helpers import encode_to_bytes
 
 
 _SERVER_MESSAGES_TUPLES = (
@@ -232,8 +233,12 @@ def __setattr__(self, name, value):
             self._msg[name] = value.get_message() \
                 if isinstance(value, Message) else value
         else:
-            if isinstance(value, (NUMERIC_TYPES, STRING_TYPES, BYTE_TYPES)):
+            if PY3 and isinstance(value, STRING_TYPES):
+                setattr(self._msg, name, encode_to_bytes(value))
+            elif isinstance(value, (NUMERIC_TYPES, STRING_TYPES, BYTE_TYPES)):
                 setattr(self._msg, name, value)
+            elif isinstance(value, list):
+                getattr(self._msg, name).extend(value)
             elif isinstance(value, Message):
                 getattr(self._msg, name).MergeFrom(value.get_message())
             else:
