Skip to content

Commit ce9a909

Browse files
committed
Change kind identifier to fully use python terminology
1 parent b5dc5a2 commit ce9a909

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

derive/src/lib.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ enum ParameterKind {
2323

2424
impl ParameterKind {
2525
fn from_ident(ident: &Ident) -> ParameterKind {
26-
if ident == "positional" {
26+
if ident == "positional_only" {
2727
ParameterKind::PositionalOnly
28-
} else if ident == "positional_keyword" {
28+
} else if ident == "positional_or_keyword" {
2929
ParameterKind::PositionalOrKeyword
30-
} else if ident == "keyword" {
30+
} else if ident == "keyword_only" {
3131
ParameterKind::KeywordOnly
3232
} else {
3333
panic!("Unrecognised attribute")

vm/src/builtins.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -537,11 +537,11 @@ fn builtin_pow(vm: &VirtualMachine, args: PyFuncArgs) -> PyResult {
537537

538538
#[derive(Debug, FromArgs)]
539539
pub struct PrintOptions {
540-
#[pyarg(keyword, default = "None")]
540+
#[pyarg(keyword_only, default = "None")]
541541
sep: Option<PyStringRef>,
542-
#[pyarg(keyword, default = "None")]
542+
#[pyarg(keyword_only, default = "None")]
543543
end: Option<PyStringRef>,
544-
#[pyarg(keyword, default = "false")]
544+
#[pyarg(keyword_only, default = "false")]
545545
flush: bool,
546546
}
547547

vm/src/obj/objint.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -374,9 +374,9 @@ impl PyIntRef {
374374

375375
#[derive(FromArgs)]
376376
struct IntOptions {
377-
#[pyarg(positional, optional = true)]
377+
#[pyarg(positional_only, optional = true)]
378378
val_options: OptionalArg<PyObjectRef>,
379-
#[pyarg(positional_keyword, optional = true)]
379+
#[pyarg(positional_or_keyword, optional = true)]
380380
base: OptionalArg<u32>,
381381
}
382382

0 commit comments

Comments
 (0)