fix: throw single complete event

AidasK · AidasK · commit b3d3e349e90c · 2013-09-27T17:04:37.000+03:00
diff --git a/src/resumable.js b/src/resumable.js
@@ -236,7 +236,7 @@
      * @returns {boolean}
      * @private
      */
-    uploadNextChunk: function () {
+    uploadNextChunk: function (preventEvents) {
       // In some cases (such as videos) it's really handy to upload the first
       // and last chunk of a file quickly; this let's the server check the file's
       // metadata and determine if there's even a point in continuing.
@@ -290,7 +290,7 @@
           return false;
         }
       });
-      if (!outstanding) {
+      if (!outstanding && !preventEvents) {
         // All chunks have been uploaded, complete
         this.fire('complete');
       }
@@ -421,8 +421,12 @@
       }
       // Kick off the queue
       this.fire('uploadStart');
+      var started = false;
       for (var num = 1; num <= this.opts.simultaneousUploads; num++) {
-        this.uploadNextChunk();
+        started = this.uploadNextChunk(true) || started;
+      }
+      if (!started) {
+        this.fire('complete');
       }
     },
 
diff --git a/test/uploadSpec.js b/test/uploadSpec.js
@@ -125,6 +125,11 @@ describe('upload file', function() {
     expect(events[10]).toBe('fileSuccess');
     // Can be sync and async
     expect(events[11]).toBe('complete');
+
+    resumable.upload();
+    expect(events.length).toBe(14);
+    expect(events[12]).toBe('uploadStart');
+    expect(events[13]).toBe('complete');
   });
 
   it('should pause and resume file', function () {
