-
Notifications
You must be signed in to change notification settings - Fork 17
Closed
Labels
Description
When a user is not logged in, the "guest" token will be sent with every HTTP request. Consequently, when the guest token expires (in 30 days), the user cannot log in again without manually deleting the guestToken from the browser cache.
Lines 36 to 40 in 705940f
setAuthToken( | |
localStorage.getItem("token") || | |
localStorage.getItem("guestToken") || | |
null | |
); |
Correct behavior:
- Short-term fix: do not send guest tokens for user signup/logins
- Long-term: the guest system has many flaws, e.g., repos not merged after registration. We need a better way to handle guests, preferably local-only with IndexedDB & Yjs.