From c51706ececb6774852cdb2dcfbaac42e19b7dfe8 Mon Sep 17 00:00:00 2001
From: Hebi Li <lihebi.com@gmail.com>
Date: Tue, 13 Dec 2022 14:47:24 -0800
Subject: [PATCH] add hasToken to avoid loading repo to early

---
 ui/src/lib/auth.tsx   | 11 +++++++++++
 ui/src/pages/repo.tsx | 29 +++++++++++++++++++++++------
 2 files changed, 34 insertions(+), 6 deletions(-)

diff --git a/ui/src/lib/auth.tsx b/ui/src/lib/auth.tsx
index b03b01c4..7c1c5a17 100644
--- a/ui/src/lib/auth.tsx
+++ b/ui/src/lib/auth.tsx
@@ -149,6 +149,9 @@ function useProvideAuth() {
     }
   };
 
+  /**
+   * This is not immediately set onrefresh.
+   */
   const isSignedIn = () => {
     if (authToken) {
       return true;
@@ -157,6 +160,13 @@ function useProvideAuth() {
     }
   };
 
+  /**
+   * This is set immediately on refresh.
+   */
+  function hasToken() {
+    return localStorage.getItem("token") !== null;
+  }
+
   return {
     createApolloClient,
     signIn,
@@ -164,5 +174,6 @@ function useProvideAuth() {
     handleGoogle,
     signUp,
     isSignedIn,
+    hasToken,
   };
 }
diff --git a/ui/src/pages/repo.tsx b/ui/src/pages/repo.tsx
index 9861b648..5b45a8a4 100644
--- a/ui/src/pages/repo.tsx
+++ b/ui/src/pages/repo.tsx
@@ -18,6 +18,7 @@ import { Header } from "../components/Header";
 import { Sidebar } from "../components/Sidebar";
 import { useLocalStorage } from "../hooks/useLocalStorage";
 import { Stack, TextField } from "@mui/material";
+import { useAuth } from "../lib/auth";
 
 const DrawerWidth = 240;
 const SIDEBAR_KEY = "sidebar";
@@ -160,6 +161,7 @@ function RepoImpl() {
   const deleteClient = useStore(store, (state) => state.deleteClient);
 
   const { loading, me } = useMe();
+  const { hasToken } = useAuth();
   useEffect(() => {
     if (me) {
       setSessionId(`${me.id}_${id}`);
@@ -184,17 +186,32 @@ function RepoImpl() {
         });
       });
     }
-  }, [provider]);
+  }, [addClient, deleteClient, provider]);
 
   useEffect(() => {
     resetState();
     setRepo(id!);
-    // load the repo. It is actually not a queue, just an async thunk
-    loadRepo(client, id!);
-    if (!loading && me) {
-      setUser(me);
+    if (hasToken()) {
+      if (!loading && me) {
+        setUser(me);
+        // load the repo. It is actually not a queue, just an async thunk
+        loadRepo(client, id!);
+      }
+    } else {
+      // not signed in, just load the repo
+      loadRepo(client, id!);
     }
-  }, [client, id, loadRepo, resetState, setRepo, me, loading, setUser]);
+  }, [
+    client,
+    id,
+    loadRepo,
+    resetState,
+    setRepo,
+    me,
+    loading,
+    setUser,
+    hasToken,
+  ]);
 
   // FIXME Removing queueL. This will cause Repo to be re-rendered a lot of
   // times, particularly the delete pod action would cause syncstatus and repo