[UI] Add a setting for Sidebar position #523
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senwang86
commented
Sep 8, 2023
| @@ -287,6 +304,7 @@ function RepoWrapper({ children, id }) { | |||
| flexGrow: 1, | |||
| verticalAlign: "top", | |||
| height: "100%", | |||
| ...(isSidebarOnLeftHand && { ml: open ? sidebar_width : 0 }), | |||
There was a problem hiding this comment.
Any better way to adjust the Canvas position?
There was a problem hiding this comment.
This is the best way I know.
|
This PR is cool. I was not able to make the left work in #521 due to flex displaying issues. Your approach looks nice. |
|
Resolved conflicts in #527 and merged. Closing. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We used to talk about giving users an option to put the Sidebar on the left or right side, feel like it's ready to provide this option after PR #521
Test