Skip to content

Commit 07a7be7

Browse files
fix use %(name)s in executemany
1 parent c3e0f2f commit 07a7be7

File tree

3 files changed

+2
-20
lines changed

3 files changed

+2
-20
lines changed

pymysql/connections.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -768,19 +768,6 @@ def show_warnings(self):
768768
result.read()
769769
return result.rows
770770

771-
def get_system_variable(self, name, default=None):
772-
"""Get settings from server"""
773-
self._execute_command(COMMAND.COM_QUERY, "SHOW VARIABLES WHERE VARIABLE_NAME = %s" % self.escape(name))
774-
result = MySQLResult(self)
775-
result.read()
776-
if result.rows:
777-
variable = result.rows[0][1]
778-
if variable.isdigit():
779-
return int(variable)
780-
else:
781-
return variable
782-
return default
783-
784771
def select_db(self, db):
785772
'''Set current db'''
786773
self._execute_command(COMMAND.COM_INIT_DB, db)
@@ -902,9 +889,6 @@ def connect(self, sock=None):
902889
self._get_server_information()
903890
self._request_authentication()
904891

905-
self.max_allowed_packet = min(self.max_allowed_packet,
906-
self.get_system_variable('max_allowed_packet', self.max_allowed_packet))
907-
908892
if self.sql_mode is not None:
909893
c = self.cursor()
910894
c.execute("SET sql_mode=%s", (self.sql_mode,))

pymysql/cursors.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ class Cursor(object):
2525
#:
2626
#: Max size of allowed statement is max_allowed_packet - packet_header_size.
2727
#: Default value of max_allowed_packet is 1048576.
28-
max_stmt_length = 1024000 * 6
29-
packet_header_size = 4
28+
max_stmt_length = 1024000
3029

3130
def __init__(self, connection):
3231
'''
@@ -41,7 +40,6 @@ def __init__(self, connection):
4140
self._executed = None
4241
self._result = None
4342
self._rows = None
44-
self.max_stmt_length = min(Cursor.max_stmt_length, connection.max_allowed_packet - Cursor.packet_header_size)
4543

4644
def close(self):
4745
'''

pymysql/tests/test_cursor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,4 @@ def test_executemany(self):
9898
# dict args
9999
data_dict = [{'data': i} for i in xrange(10)]
100100
cursor.executemany("insert into test (data) values (%(data)s)", data_dict)
101-
self.assertTrue(cursor._executed.endswith(",(7),(8),(9)"), 'execute many with %(data)s not in one query')
101+
self.assertTrue(cursor._executed.endswith(",(7),(8),(9)"), 'execute many with %(data)s not in one query')

0 commit comments

Comments
 (0)