Simplify valid path check

code-asher · code-asher · commit 543d64268d3d · 2020-08-05T13:00:34.000-05:00
diff --git a/src/node/app/static.ts b/src/node/app/static.ts
@@ -39,7 +39,7 @@ export class StaticHttpProvider extends HttpProvider {
 
     // Make sure it's in code-server or a plugin.
     const validPaths = [this.rootPath, process.env.PLUGIN_DIR]
-    if (!validPaths.find((p) => typeof p !== "undefined" && p.length > 0 && resourcePath.startsWith(p))) {
+    if (!validPaths.find((p) => p && resourcePath.startsWith(p))) {
       this.ensureAuthenticated(request)
     }
 

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ export class StaticHttpProvider extends HttpProvider {`
`39`	`39`
`40`	`40`	`// Make sure it's in code-server or a plugin.`
`41`	`41`	`const validPaths = [this.rootPath, process.env.PLUGIN_DIR]`
`42`		`- if (!validPaths.find((p) => typeof p !== "undefined" && p.length > 0 && resourcePath.startsWith(p))) {`
	`42`	`+ if (!validPaths.find((p) => p && resourcePath.startsWith(p))) {`
`43`	`43`	`this.ensureAuthenticated(request)`
`44`	`44`	`}`
`45`	`45`