Fix: use pipe to spawn child process to re-enable file logging (#4293)

tianjianchn · web-flow · commit 59f667ec146a · 2021-10-05T10:55:40.000-05:00
We pipe the child's stdout and stderr to the log file (and to the parent's streams) but since we used `inherit` for `stdio` this caused the child to use the parent's streams directly which made `child.stdout` and `child.stderr` non-existent and thus we had no file logging.

Using `pipe` creates stdin and stderr on the child.
diff --git a/src/node/wrapper.ts b/src/node/wrapper.ts
@@ -314,7 +314,7 @@ export class ParentProcess extends Process {
         CODE_SERVER_PARENT_PID: process.pid.toString(),
         NODE_OPTIONS: `--max-old-space-size=2048 ${process.env.NODE_OPTIONS || ""}`,
       },
-      stdio: ["inherit", "inherit", "inherit", "ipc"],
+      stdio: ["pipe", "pipe", "pipe", "ipc"],
     })
   }
 

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,7 @@ export class ParentProcess extends Process {`
`314`	`314`	`CODE_SERVER_PARENT_PID: process.pid.toString(),`
`315`	`315`	NODE_OPTIONS: `--max-old-space-size=2048 ${process.env.NODE_OPTIONS \|\| ""}`,
`316`	`316`	`},`
`317`		`- stdio: ["inherit", "inherit", "inherit", "ipc"],`
	`317`	`+ stdio: ["pipe", "pipe", "pipe", "ipc"],`
`318`	`318`	`})`
`319`	`319`	`}`
`320`	`320`