Fix cleanup after getting message from vscode

code-asher · code-asher · commit 72931edcf010 · 2020-11-12T11:16:21.000-06:00
diff --git a/src/node/vscode.ts b/src/node/vscode.ts
@@ -123,25 +123,30 @@ export class VscodeProvider {
     fn: (message: ipc.VscodeMessage) => message is T,
   ): Promise<T> {
     return new Promise((resolve, _reject) => {
-      const reject = (error: Error) => {
+      const cleanup = () => {
+        proc.off("error", reject)
+        proc.off("exit", onExit)
         clearTimeout(timeout)
+      }
+
+      const timeout = setTimeout(() => {
+        cleanup()
+        _reject(new Error("timed out"))
+      }, this.timeoutInterval)
+
+      const reject = (error: Error) => {
+        cleanup()
         _reject(error)
       }
 
       const onExit = (code: number | null) => {
         reject(new Error(`VS Code exited unexpectedly with code ${code}`))
       }
 
-      const timeout = setTimeout(() => {
-        reject(new Error("timed out"))
-      }, this.timeoutInterval)
-
       proc.on("message", (message: ipc.VscodeMessage) => {
         logger.debug("got message from vscode", field("message", message))
-        proc.off("error", reject)
-        proc.off("exit", onExit)
         if (fn(message)) {
-          clearTimeout(timeout)
+          cleanup()
           resolve(message)
         }
       })
