docs(patches): add testing notes for node-version

jsjoeio · jsjoeio · commit 786f0872d63b · 2022-04-29T17:05:00.000-07:00
diff --git a/patches/node-version.diff b/patches/node-version.diff
@@ -8,7 +8,7 @@ To test this:
 
 1. build fresh Coder workspace
 2. clone code-server
-3. `yarn watch`
+3. `yarn build && yarn build:vscode && KEEP_MODULES=1 yarn release`
 4. test built-in terminal
 
 Index: code-server/lib/vscode/build/gulpfile.reh.js
@@ -17,14 +17,14 @@ Index: code-server/lib/vscode/build/gulpfile.reh.js
 +++ code-server/lib/vscode/build/gulpfile.reh.js
 @@ -125,9 +125,7 @@ const serverWithWebEntryPoints = [
  ];
- 
+
  function getNodeVersion() {
 -	const yarnrc = fs.readFileSync(path.join(REPO_ROOT, 'remote', '.yarnrc'), 'utf8');
 -	const target = /^target "(.*)"$/m.exec(yarnrc)[1];
 -	return target;
 +	return process.versions.node;
  }
- 
+
  const nodeVersion = getNodeVersion();
 Index: code-server/lib/vscode/build/lib/node.js
 ===================================================================
@@ -47,13 +47,13 @@ Index: code-server/lib/vscode/build/lib/node.ts
 +++ code-server/lib/vscode/build/lib/node.ts
 @@ -7,9 +7,7 @@ import * as path from 'path';
  import * as fs from 'fs';
- 
+
  const root = path.dirname(path.dirname(__dirname));
 -const yarnrcPath = path.join(root, 'remote', '.yarnrc');
 -const yarnrc = fs.readFileSync(yarnrcPath, 'utf8');
 -const version = /^target\s+"([^"]+)"$/m.exec(yarnrc)![1];
 +const version = process.versions.node;
- 
+
  const platform = process.platform;
  const arch = process.arch;
 Index: code-server/lib/vscode/build/lib/util.js
@@ -75,16 +75,16 @@ Index: code-server/lib/vscode/build/lib/util.ts
 ===================================================================
 --- code-server.orig/lib/vscode/build/lib/util.ts
 +++ code-server/lib/vscode/build/lib/util.ts
-@@ -371,9 +371,7 @@ export function streamToPromise(stream: 
+@@ -371,9 +371,7 @@ export function streamToPromise(stream:
  }
- 
+
  export function getElectronVersion(): string {
 -	const yarnrc = fs.readFileSync(path.join(root, '.yarnrc'), 'utf8');
 -	const target = /^target "(.*)"$/m.exec(yarnrc)![1];
 -	return target;
 +	return process.versions.node;
  }
- 
+
  export function acquireWebNodePaths() {
 @@ -455,4 +453,3 @@ export function buildWebNodePaths(outDir
  	result.taskName = 'build-web-node-paths';
@@ -98,7 +98,7 @@ Index: code-server/lib/vscode/build/npm/preinstall.js
 @@ -32,6 +32,13 @@ if (!/yarn[\w-.]*\.c?js$|yarnpkg$/.test(
  	err = true;
  }
- 
+
 +fs.rmSync(path.join(__dirname, '..', '..', '.yarnrc'), {
 +	force: true
 +});
