Add "CODE_SERVER_HOST" environment variable (#6423)

Cyanoure · web-flow · commit a76e5241b6be · 2023-09-08T22:50:11.000Z
diff --git a/src/node/cli.ts b/src/node/cli.ts
@@ -732,6 +732,9 @@ export function bindAddrFromArgs(addr: Addr, args: UserProvidedArgs): Addr {
   if (args["bind-addr"]) {
     addr = parseBindAddr(args["bind-addr"])
   }
+  if (process.env.CODE_SERVER_HOST) {
+    addr.host = process.env.CODE_SERVER_HOST
+  }
   if (args.host) {
     addr.host = args.host
   }
diff --git a/test/unit/node/cli.test.ts b/test/unit/node/cli.test.ts
@@ -789,6 +789,50 @@ describe("bindAddrFromArgs", () => {
     expect(actual).toStrictEqual(expected)
   })
 
+  it("should use process.env.CODE_SERVER_HOST if set", () => {
+    const [setValue, resetValue] = useEnv("CODE_SERVER_HOST")
+    setValue("coder")
+
+    const args: UserProvidedArgs = {}
+
+    const addr = {
+      host: "localhost",
+      port: 8080,
+    }
+
+    const actual = bindAddrFromArgs(addr, args)
+    const expected = {
+      host: "coder",
+      port: 8080,
+    }
+
+    expect(actual).toStrictEqual(expected)
+    resetValue()
+  })
+
+  it("should use the args.host over process.env.CODE_SERVER_HOST if both set", () => {
+    const [setValue, resetValue] = useEnv("CODE_SERVER_HOST")
+    setValue("coder")
+
+    const args: UserProvidedArgs = {
+      host: "123.123.123.123",
+    }
+
+    const addr = {
+      host: "localhost",
+      port: 8080,
+    }
+
+    const actual = bindAddrFromArgs(addr, args)
+    const expected = {
+      host: "123.123.123.123",
+      port: 8080,
+    }
+
+    expect(actual).toStrictEqual(expected)
+    resetValue()
+  })
+
   it("should use process.env.PORT if set", () => {
     const [setValue, resetValue] = useEnv("PORT")
     setValue("8000")

Original file line number	Diff line number	Diff line change
`@@ -732,6 +732,9 @@ export function bindAddrFromArgs(addr: Addr, args: UserProvidedArgs): Addr {`
`732`	`732`	`if (args["bind-addr"]) {`
`733`	`733`	`addr = parseBindAddr(args["bind-addr"])`
`734`	`734`	`}`
	`735`	`+ if (process.env.CODE_SERVER_HOST) {`
	`736`	`+ addr.host = process.env.CODE_SERVER_HOST`
	`737`	`+ }`
`735`	`738`	`if (args.host) {`
`736`	`739`	`addr.host = args.host`
`737`	`740`	`}`