fix(http): escape req.query.to in replaceTemplates

jsjoeio · jsjoeio · commit c0e123a8012c · 2021-07-01T10:43:37.000-07:00
diff --git a/src/node/http.ts b/src/node/http.ts
@@ -7,7 +7,7 @@ import { normalize, Options } from "../common/util"
 import { AuthType, DefaultedArgs } from "./cli"
 import { commit, rootPath } from "./constants"
 import { Heart } from "./heart"
-import { getPasswordMethod, IsCookieValidArgs, isCookieValid, sanitizeString } from "./util"
+import { getPasswordMethod, IsCookieValidArgs, isCookieValid, sanitizeString, escapeHtml } from "./util"
 
 declare global {
   // eslint-disable-next-line @typescript-eslint/no-namespace
@@ -35,7 +35,7 @@ export const replaceTemplates = <T extends object>(
     ...extraOpts,
   }
   return content
-    .replace(/{{TO}}/g, (typeof req.query.to === "string" && req.query.to) || "/")
+    .replace(/{{TO}}/g, (typeof req.query.to === "string" && escapeHtml(req.query.to)) || "/")
     .replace(/{{BASE}}/g, options.base)
     .replace(/{{CS_STATIC_BASE}}/g, options.csStaticBase)
     .replace(/"{{OPTIONS}}"/, `'${JSON.stringify(options)}'`)
diff --git a/src/node/routes/login.ts b/src/node/routes/login.ts
@@ -112,7 +112,7 @@ router.post("/", async (req, res) => {
 
     throw new Error("Incorrect password")
   } catch (error) {
-    const htmlToRender = await getRoot(req, error)
-    res.send(htmlToRender)
+    const renderedHtml = await getRoot(req, error)
+    res.send(renderedHtml)
   }
 })
diff --git a/test/unit/routes/login.test.ts b/test/unit/routes/login.test.ts
@@ -1,8 +1,7 @@
+import { RateLimiter } from "../../../src/node/routes/login"
 import * as httpserver from "../../utils/httpserver"
 import * as integration from "../../utils/integration"
 
-import { RateLimiter } from "../../../src/node/routes/login"
-
 describe("login", () => {
   describe("RateLimiter", () => {
     it("should allow one try ", () => {
@@ -56,8 +55,12 @@ describe("login", () => {
       _codeServer = await integration.setup(["--auth=password"], "")
     })
 
-    afterEach(() => {
+    afterEach(async () => {
       process.env.PASSWORD = previousEnvPassword
+      if (_codeServer) {
+        await _codeServer.close()
+        _codeServer = undefined
+      }
     })
 
     it("should return HTML with 'Missing password' message", async () => {

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ router.post("/", async (req, res) => {`
`112`	`112`
`113`	`113`	`throw new Error("Incorrect password")`
`114`	`114`	`} catch (error) {`
`115`		`- const htmlToRender = await getRoot(req, error)`
`116`		`- res.send(htmlToRender)`
	`115`	`+ const renderedHtml = await getRoot(req, error)`
	`116`	`+ res.send(renderedHtml)`
`117`	`117`	`}`
`118`	`118`	`})`