Require minimum node 12

nhooyr · nhooyr · commit d4b3d21dceb3 · 2020-05-14T22:33:12.000-04:00
diff --git a/README.md b/README.md
@@ -41,6 +41,8 @@ platform or architecture.
 **note:** Installing via `npm` requires certain dependencies for the native module builds.
 See [./doc/npm.md](./doc/npm.md) for installing these dependencies.
 
+You also need at least node v12 installed. See [#1633](https://github.com/cdr/code-server/issues/1633).
+
 ```bash
 npm install -g code-server
 code-server
diff --git a/ci/build/npm-postinstall.sh b/ci/build/npm-postinstall.sh
@@ -2,6 +2,16 @@
 set -eu
 
 main() {
+  # Grabs the major version of node from $npm_config_user_agent which looks like
+  # yarn/1.21.1 npm/? node/v14.2.0 darwin x64
+  major_node_version=$(echo "$npm_config_user_agent" | sed -n 's/.*node\/v\([^.]*\).*/\1/p')
+  if [ "$major_node_version" -lt 12 ]; then
+    echo "code-server currently requires at least node v12"
+    echo "We have detected that you are on node v$major_node_version"
+    echo "See https://github.com/cdr/code-server/issues/1633"
+    exit 1
+  fi
+
   case "${npm_config_user_agent-}" in npm*)
     # We are running under npm.
     if [ "${npm_config_unsafe_perm-}" != "true" ]; then
diff --git a/ci/steps/publish-npm.sh b/ci/steps/publish-npm.sh
@@ -11,7 +11,7 @@ main() {
 
   download_artifact npm-package ./release
   # https://github.com/actions/upload-artifact/issues/38
-  chmod +x $(grep -rl '^#!/.\+' release)
+  chmod +x $(grep -rl '^#!/.*' release)
   yarn publish --non-interactive release
 }
 
diff --git a/ci/steps/release-static.sh b/ci/steps/release-static.sh
@@ -5,7 +5,7 @@ main() {
   cd "$(dirname "$0")/../.."
 
   # https://github.com/actions/upload-artifact/issues/38
-  chmod +x $(grep -rl '^#!/.\+' release)
+  chmod +x $(grep -rl '^#!/.*' release)
 
   yarn release:static
   yarn test:static-release
diff --git a/doc/CONTRIBUTING.md b/doc/CONTRIBUTING.md
@@ -9,7 +9,7 @@ Please refer to [VS Code's prerequisites](https://github.com/Microsoft/vscode/wi
 
 Differences:
 
-- We are not constrained by node version
+- We require at least node v12 but later versions should work
 - We use [fnpm](https://github.com/goreleaser/nfpm) to build .deb and .rpm packages
 
 ## Development Workflow
diff --git a/doc/npm.md b/doc/npm.md
@@ -3,6 +3,8 @@
 If you're installing the npm module you'll need certain dependencies to build
 the native modules used by VS Code.
 
+You also need at least node v12 installed. See [#1633](https://github.com/cdr/code-server/issues/1633).
+
 ## Ubuntu, Debian
 
 ```bash
diff --git a/package.json b/package.json
@@ -92,5 +92,8 @@
     "coder",
     "vscode-remote",
     "browser-ide"
-  ]
+  ],
+  "engines": {
+    "node": ">= 12"
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ main() {`
`11`	`11`
`12`	`12`	`download_artifact npm-package ./release`
`13`	`13`	`# https://github.com/actions/upload-artifact/issues/38`
`14`		`- chmod +x $(grep -rl '^#!/.\+' release)`
	`14`	`+ chmod +x $(grep -rl '^#!/.*' release)`
`15`	`15`	`yarn publish --non-interactive release`
`16`	`16`	`}`
`17`	`17`