Skip to content

[Bug]: Tar Archives for releases contain broken symlinks #6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
davellas opened this issue Apr 11, 2023 · 2 comments
Closed
4 tasks done

[Bug]: Tar Archives for releases contain broken symlinks #6139

davellas opened this issue Apr 11, 2023 · 2 comments
Labels
bug Something isn't working duplicate

Comments

@davellas
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

Not-relevant

Steps to Reproduce

  1. download any release e.g. code-server-4.11.0-linux-amd64.tar.gz
  2. folder /lib/vscode/extensions/node_modules/.bin contains broken links pointing to /lib/vscode/extensions/node_modules/typescript/bin that is not existing

Expected

The tar archives shouldn't contain broken symlinks as that can break certain archiving tools.
Manually untarring the file will work, but not all similar tools will.

Actual

The tar archives contain broken symlinks resulting in errors when extracting the archive with certain tools

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code or GitHub Codespaces?

  • I cannot reproduce this in VS Code.
  • I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

No response
@davellas davellas added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Apr 11, 2023
@code-asher
Copy link
Member

code-asher commented Apr 11, 2023 •
edited
Loading

Ah yeah for some reason VS Code leaves broken symlinks. We remove them before publishing the deb and rpm but not for the tars. We should move that line so it applies to all the release packages.

code-server/ci/build/build-packages.sh

Line 56 in aed1fc0

rm -fr "./release-standalone/lib/vscode/extensions/node_modules/.bin"

@code-asher
Copy link
Member

Duplicate of #5157

@code-asher code-asher marked this as a duplicate of #5157 Jul 12, 2024
@code-asher code-asher closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2024
@code-asher code-asher added duplicate and removed triage This issue needs to be triaged by a maintainer labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code-asher @davellas