Skip to content

Integrated Terminal does not open at startup and is not persistent on refresh #6919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
schettn opened this issue Jul 24, 2024 · 11 comments
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@schettn
Copy link

schettn commented Jul 24, 2024

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Chrome
  • Local OS: MacOS
  • Remote OS:
  • Remote Architecture:
  • code-server --version:
    1.84.2
    0c98611
    x64

Steps to Reproduce

  1. Open code-server in browser
  2. See that there is no integrated terminal open at startup
  3. Open a new terminal
  4. Reload window
  5. See that the terminal does not re-open.

Expected

  1. A integrated terminal should be opened on first load
  2. The terminal should persist on reloads.

Both points do work in to GitHub CodeSpaces.

Actual

Neither.

Logs

No response

Screenshot/Video

Screen.Recording.2024-07-24.at.09.54.49.mov

Does this bug reproduce in native VS Code?

I did not test native VS Code

Does this bug reproduce in GitHub Codespaces?

No, this works as expected in GitHub Codespaces

Are you accessing code-server over a secure context?

  • I am using a secure context.

Notes

With "persisted" I do not mean the terminal sessions but the persistence of of the opening state.

@schettn schettn added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Jul 24, 2024
@schettn
Copy link
Author

schettn commented Jul 24, 2024

Codespaces:

Screen.Recording.2024-07-24.at.09.59.31.mov

@code-asher
Copy link
Member

code-asher commented Jul 24, 2024

1.84.2 is a bit old (Codespaces is running 1.91.1), does this persist on code-server 4.91.1?

@code-asher code-asher removed the triage This issue needs to be triaged by a maintainer label Jul 24, 2024
@schettn
Copy link
Author

schettn commented Jul 25, 2024

I installed coder just recently by following https://coder.com/docs/install.

I thought that I am on the latest version. How can I check the version of code-server?

coder version
Coder v2.13.0+56bf386 Tue Jul  2 17:54:06 UTC 2024
https://github.com/coder/coder/commit/56bf386b15128c986ad4172c1932c13bed626d58

Full build of Coder, supports the  server  subcommand.

@schettn
Copy link
Author

schettn commented Jul 25, 2024

code-server --version:
1.84.2
0c98611
x64

What is the use for this commit hash? According to the commit I am on v4.91.1, don't I?

@code-asher
Copy link
Member

code-asher commented Jul 25, 2024

Your is on v4.19.1-rc.2 (19, not 91).

Coder and code-server are two separate unrelated products (although they are often used together), looks like you have the latest version of Coder but not the latest version of code-server.

@schettn
Copy link
Author

schettn commented Jul 26, 2024

I could not figure out how to update this because I am on the latest coder version and I thought that coder updates code-server.

Now I figured out that the code-server version is specified in the terraform file of the template. It seems like your docker getting-started template use an old version of code-server.

image

@code-asher
Copy link
Member

Oh! Yeah you are right. I will update the template, thank you for pointing that out.

@code-asher
Copy link
Member

coder/coder#14030

@schettn
Copy link
Author

schettn commented Aug 5, 2024

@code-asher Do you know a way to open up the terminal the first time after the workspace is created?

@code-asher
Copy link
Member

I am not sure if you can do it only the first time, but it might work to use tasks.json, for example:

{
  "version": "2.0.0",
  "tasks": [{
    "label": "open terminal on folder open",
    "command": "${command:workbench.action.terminal.toggleTerminal}",
    "runOptions": {
      "runOn": "folderOpen"
    }
  }]
}

@code-asher
Copy link
Member

Closing for now but let me know if you come back to this and it reproduces in the latest version.

@code-asher code-asher closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants