From 39784e78950f3794e814e4d974d66744b0cdf2dc Mon Sep 17 00:00:00 2001 From: Thomas John Wesolowski Date: Mon, 7 Feb 2022 21:47:22 -0600 Subject: [PATCH 1/3] add support for imagePullSecrets --- ci/helm-chart/templates/deployment.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ci/helm-chart/templates/deployment.yaml b/ci/helm-chart/templates/deployment.yaml index 3f0d11d5c600..90e7395d4326 100644 --- a/ci/helm-chart/templates/deployment.yaml +++ b/ci/helm-chart/templates/deployment.yaml @@ -21,6 +21,10 @@ spec: app.kubernetes.io/name: {{ include "code-server.name" . }} app.kubernetes.io/instance: {{ .Release.Name }} spec: + {{- with .Values.imagePullSecrets }} + imagePullSecrets: + {{- toYaml . | nindent 8 }} + {{- end }} {{- if .Values.hostnameOverride }} hostname: {{ .Values.hostnameOverride }} {{- end }} From e0a657f98de2a3511ecab201cb27ede0d5c03a11 Mon Sep 17 00:00:00 2001 From: Thomas John Wesolowski Date: Tue, 8 Feb 2022 22:46:27 -0600 Subject: [PATCH 2/3] Add doc and example value for imagePullSecrets --- ci/helm-chart/values.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ci/helm-chart/values.yaml b/ci/helm-chart/values.yaml index 9dfc948138f9..46f45dbaee47 100644 --- a/ci/helm-chart/values.yaml +++ b/ci/helm-chart/values.yaml @@ -9,7 +9,12 @@ image: tag: '4.0.2' pullPolicy: Always +# Specifies one or more secrets to be used when pulling images from a +# private container repository +# https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry imagePullSecrets: [] +# - name: registry-creds + nameOverride: "" fullnameOverride: "" hostnameOverride: "" From 229d3014ba9f6c5d1e843559160cac7500038ccd Mon Sep 17 00:00:00 2001 From: Thomas John Wesolowski Date: Sat, 12 Feb 2022 20:17:15 -0600 Subject: [PATCH 3/3] simplify syntax for imagePullSecrets --- ci/helm-chart/templates/deployment.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ci/helm-chart/templates/deployment.yaml b/ci/helm-chart/templates/deployment.yaml index 90e7395d4326..f137a9d2a8b6 100644 --- a/ci/helm-chart/templates/deployment.yaml +++ b/ci/helm-chart/templates/deployment.yaml @@ -21,10 +21,7 @@ spec: app.kubernetes.io/name: {{ include "code-server.name" . }} app.kubernetes.io/instance: {{ .Release.Name }} spec: - {{- with .Values.imagePullSecrets }} - imagePullSecrets: - {{- toYaml . | nindent 8 }} - {{- end }} + imagePullSecrets: {{- toYaml .Values.imagePullSecrets | nindent 8 }} {{- if .Values.hostnameOverride }} hostname: {{ .Values.hostnameOverride }} {{- end }}