fix: use error log when failing provisioner job (#6812)

ElliotG · coadler · web-flow · commit 0069831e8ddc · 2023-04-05T13:30:53.000-05:00
Co-authored-by: Colin Adler &lt;colin1adler@gmail.com&gt;
diff --git a/provisionerd/provisionerd_test.go b/provisionerd/provisionerd_test.go
@@ -1011,7 +1011,7 @@ func TestProvisionerd(t *testing.T) {
 		t.Cleanup(func() {
 			close(done)
 		})
-		logger := slogtest.Make(t, nil)
+		logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true})
 		m := sync.Mutex{}
 		var ops []string
 		completeChan := make(chan struct{})
@@ -1120,7 +1120,7 @@ func createTar(t *testing.T, files map[string]string) []byte {
 // Creates a provisionerd implementation with the provided dialer and provisioners.
 func createProvisionerd(t *testing.T, dialer provisionerd.Dialer, provisioners provisionerd.Provisioners) *provisionerd.Server {
 	server := provisionerd.New(dialer, &provisionerd.Options{
-		Logger:          slogtest.Make(t, nil).Named("provisionerd").Leveled(slog.LevelDebug),
+		Logger:          slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Named("provisionerd").Leveled(slog.LevelDebug),
 		JobPollInterval: 50 * time.Millisecond,
 		UpdateInterval:  50 * time.Millisecond,
 		Provisioners:    provisioners,
diff --git a/provisionerd/runner/runner.go b/provisionerd/runner/runner.go
@@ -900,7 +900,7 @@ func (r *Runner) buildWorkspace(ctx context.Context, stage string, req *sdkproto
 			})
 		case *sdkproto.Provision_Response_Complete:
 			if msgType.Complete.Error != "" {
-				r.logger.Warn(context.Background(), "provision failed; updating state",
+				r.logger.Error(context.Background(), "provision failed; updating state",
 					slog.F("state_length", len(msgType.Complete.State)),
 					slog.F("error", msgType.Complete.Error),
 				)

Original file line number	Diff line number	Diff line change
`@@ -900,7 +900,7 @@ func (r Runner) buildWorkspace(ctx context.Context, stage string, req sdkproto`
`900`	`900`	`})`
`901`	`901`	`case *sdkproto.Provision_Response_Complete:`
`902`	`902`	`if msgType.Complete.Error != "" {`
`903`		`- r.logger.Warn(context.Background(), "provision failed; updating state",`
	`903`	`+ r.logger.Error(context.Background(), "provision failed; updating state",`
`904`	`904`	`slog.F("state_length", len(msgType.Complete.State)),`
`905`	`905`	`slog.F("error", msgType.Complete.Error),`
`906`	`906`	`)`