convert sentinel string to an error

hugodutka · hugodutka · commit 00b813196778 · 2024-11-15T17:40:01.000Z
diff --git a/provisioner/terraform/resources.go b/provisioner/terraform/resources.go
@@ -134,6 +134,8 @@ type State struct {
 	ExternalAuthProviders []*proto.ExternalAuthProviderResource
 }
 
+var ErrInvalidTerraformAddr = xerrors.New("invalid terraform address")
+
 // ConvertState consumes Terraform state and a GraphViz representation
 // produced by `terraform graph` to produce resources consumable by Coder.
 // nolint:gocognit // This function makes more sense being large for now, until refactored.
@@ -609,7 +611,7 @@ func ConvertState(ctx context.Context, modules []*tfjson.StateModule, rawGraph s
 				// the database, a null value in WorkspaceResource's ModulePath
 				// indicates "this resource was created before module paths
 				// were tracked."
-				modulePath = "FAILED_TO_PARSE_TERRAFORM_ADDRESS"
+				modulePath = fmt.Sprintf("%s", ErrInvalidTerraformAddr)
 				logger.Error(ctx, "failed to parse Terraform address", slog.F("address", resource.Address))
 			}
 
diff --git a/provisioner/terraform/resources_test.go b/provisioner/terraform/resources_test.go
@@ -816,6 +816,25 @@ func TestConvertResources(t *testing.T) {
 	}
 }
 
+func TestInvalidTerraformAddress(t *testing.T) {
+	t.Parallel()
+	ctx, logger := context.Background(), slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Leveled(slog.LevelDebug)
+	state, err := terraform.ConvertState(ctx, []*tfjson.StateModule{{
+		Resources: []*tfjson.StateResource{{
+			Address:         "invalid",
+			Type:            "invalid",
+			Name:            "invalid",
+			Mode:            tfjson.ManagedResourceMode,
+			AttributeValues: map[string]interface{}{},
+		}},
+		// This is manually created to join the edges.
+	}}, `digraph {}`, logger)
+	require.Nil(t, err)
+	require.Len(t, state.Resources, 1)
+	require.Equal(t, state.Resources[0].Name, "invalid")
+	require.Equal(t, state.Resources[0].ModulePath, "invalid terraform address")
+}
+
 func TestAppSlugValidation(t *testing.T) {
 	t.Parallel()
 	ctx, logger := ctxAndLogger(t)
