Generator was not handling "nil" slices correctly

Emyrk · Emyrk · commit 012e2cb38ebc · 2023-03-21T16:45:33.000-05:00
diff --git a/coderd/database/dbgen/take.go b/coderd/database/dbgen/take.go
@@ -1,10 +1,10 @@
 package dbgen
 
-import "net"
+import (
+	"net"
+)
 
 func takeFirstIP(values ...net.IPNet) net.IPNet {
-	takeFirstSlice([]string{})
-
 	return takeFirstF(values, func(v net.IPNet) bool {
 		return len(v.IP) != 0 && len(v.Mask) != 0
 	})
@@ -14,19 +14,22 @@ func takeFirstIP(values ...net.IPNet) net.IPNet {
 // []any is not a comparable type.
 func takeFirstSlice[T any](values ...[]T) []T {
 	return takeFirstF(values, func(v []T) bool {
-		return len(v) != 0
+		return v != nil && len(v) != 0
 	})
 }
 
 // takeFirstF takes the first value that returns true
 func takeFirstF[Value any](values []Value, take func(v Value) bool) Value {
-	var empty Value
 	for _, v := range values {
 		if take(v) {
 			return v
 		}
 	}
-	// If all empty, return empty
+	// If all empty, return the last element
+	if len(values) > 0 {
+		return values[len(values)-1]
+	}
+	var empty Value
 	return empty
 }
 
