Skip to content

Commit 016c56d

Browse files
committed
Check returned error from db call
1 parent 5a0e5a2 commit 016c56d

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

coderd/authzquery/methods_test.go

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,17 @@ MethodLoop:
116116
method := azt.Method(i)
117117
if method.Name == methodName {
118118
resp := reflect.ValueOf(az).Method(i).Call(append([]reflect.Value{reflect.ValueOf(ctx)}, testCase.Inputs...))
119-
var _ = resp
119+
// TODO: Should we assert the object returned is the correct one?
120+
for _, r := range resp {
121+
if r.Type().Implements(reflect.TypeOf((*error)(nil)).Elem()) {
122+
err, ok := r.Interface().(error)
123+
if !ok {
124+
t.Fatal("error is not an error?!")
125+
}
126+
require.NoError(t, err, "method %q returned an error", testName)
127+
break
128+
}
129+
}
120130
found = true
121131
break MethodLoop
122132
}

0 commit comments

Comments
 (0)