Skip to content

Commit 0305587

Browse files
committed
fix process group kill invocation
1 parent 52b2589 commit 0305587

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

scripts/develop.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ set -u
1414

1515
# Preflight checks: ensure we have our required dependencies, and make sure nothing is listening on port 3000 or 8080
1616
dependencies curl git go make nc yarn
17-
nc -z localhost 3000 && echo '== ERROR: something is listening on port 3000. Kill it and re-run this script.' && exit 1
18-
nc -z localhost 8080 && echo '== ERROR: something is listening on port 8080. Kill it and re-run this script.' && exit 1
17+
nc -z 127.0.0.1 3000 >/dev/null 2>&1 && echo '== ERROR: something is listening on port 3000. Kill it and re-run this script.' && exit 1
18+
nc -z 127.0.0.1 8080 >/dev/null 2>&1 && echo '== ERROR: something is listening on port 8080. Kill it and re-run this script.' && exit 1
1919

2020
echo '== Run "make build" before running this command to build binaries.'
2121
echo '== Without these binaries, workspaces will fail to start!'
@@ -29,8 +29,8 @@ echo '== Without these binaries, workspaces will fail to start!'
2929
(
3030
SCRIPT_PID=$$
3131
cd "${PROJECT_ROOT}"
32-
CODERV2_HOST=http://127.0.0.1:3000 INSPECT_XSTATE=true yarn --cwd=./site dev || kill -INT ${SCRIPT_PID} &
33-
go run -tags embed cmd/coder/main.go server --in-memory --tunnel || kill -INT ${SCRIPT_PID} &
32+
CODERV2_HOST=http://127.0.0.1:3000 INSPECT_XSTATE=true yarn --cwd=./site dev || kill -INT -${SCRIPT_PID} &
33+
go run -tags embed cmd/coder/main.go server --address 127.0.0.1:3000 --in-memory --tunnel || kill -INT -${SCRIPT_PID} &
3434

3535
echo '== Waiting for Coder to become ready'
3636
timeout 60s bash -c 'until curl -s --fail http://localhost:3000 > /dev/null 2>&1; do sleep 0.5; done'

0 commit comments

Comments
 (0)