fix: set default sshMaxTimeout to 60s (#7532)

mtojek · web-flow · commit 049e55767513 · 2023-05-15T10:40:19.000-05:00
* fix: set default sshMaxTimeout to 60s

* fix
diff --git a/cli/agent.go b/cli/agent.go
@@ -263,7 +263,7 @@ func (r *RootCmd) workspaceAgent() *clibase.Cmd {
 		},
 		{
 			Flag:        "ssh-max-timeout",
-			Default:     "0",
+			Default:     "60s",
 			Env:         "CODER_AGENT_SSH_MAX_TIMEOUT",
 			Description: "Specify the max timeout for a SSH connection.",
 			Value:       clibase.DurationOf(&sshMaxTimeout),
diff --git a/cli/testdata/coder_agent_--help.golden b/cli/testdata/coder_agent_--help.golden
@@ -21,7 +21,7 @@ Starts the Coder workspace agent.
       --prometheus-address string, $CODER_AGENT_PROMETHEUS_ADDRESS (default: 127.0.0.1:2112)
           The bind address to serve Prometheus metrics.
 
-      --ssh-max-timeout duration, $CODER_AGENT_SSH_MAX_TIMEOUT (default: 0)
+      --ssh-max-timeout duration, $CODER_AGENT_SSH_MAX_TIMEOUT (default: 60s)
           Specify the max timeout for a SSH connection.
 
       --tailnet-listen-port int, $CODER_AGENT_TAILNET_LISTEN_PORT (default: 0)

Original file line number	Diff line number	Diff line change
`@@ -263,7 +263,7 @@ func (r RootCmd) workspaceAgent() clibase.Cmd {`
`263`	`263`	`},`
`264`	`264`	`{`
`265`	`265`	`Flag: "ssh-max-timeout",`
`266`		`- Default: "0",`
	`266`	`+ Default: "60s",`
`267`	`267`	`Env: "CODER_AGENT_SSH_MAX_TIMEOUT",`
`268`	`268`	`Description: "Specify the max timeout for a SSH connection.",`
`269`	`269`	`Value: clibase.DurationOf(&sshMaxTimeout),`