handle window paths

mafredri · mafredri · commit 04f3bcb2fca4 · 2024-02-19T14:09:00.000+02:00
diff --git a/agent/agent.go b/agent/agent.go
@@ -968,7 +968,7 @@ func (a *agent) updateCommandEnv(current []string) (updated []string, err error)
 	if _, ok := envs["PATH"]; !ok {
 		envs["PATH"] = os.Getenv("PATH")
 	}
-	envs["PATH"] = a.scriptRunner.ScriptBinDir() + ":" + envs["PATH"]
+	envs["PATH"] = fmt.Sprintf("%s%c%s", a.scriptRunner.ScriptBinDir(), filepath.ListSeparator, envs["PATH"])
 
 	for k, v := range envs {
 		updated = append(updated, fmt.Sprintf("%s=%s", k, v))

Original file line number	Diff line number	Diff line change
`@@ -968,7 +968,7 @@ func (a *agent) updateCommandEnv(current []string) (updated []string, err error)`
`968`	`968`	`if _, ok := envs["PATH"]; !ok {`
`969`	`969`	`envs["PATH"] = os.Getenv("PATH")`
`970`	`970`	`}`
`971`		`- envs["PATH"] = a.scriptRunner.ScriptBinDir() + ":" + envs["PATH"]`
	`971`	`+ envs["PATH"] = fmt.Sprintf("%s%c%s", a.scriptRunner.ScriptBinDir(), filepath.ListSeparator, envs["PATH"])`
`972`	`972`
`973`	`973`	`for k, v := range envs {`
`974`	`974`	`updated = append(updated, fmt.Sprintf("%s=%s", k, v))`