better test

mtojek · mtojek · commit 0584d15468a4 · 2024-02-12T14:21:14.000+01:00
diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go
@@ -2552,6 +2552,10 @@ func TestWorkspaceResource(t *testing.T) {
 		})
 		user := coderdtest.CreateFirstUser(t, client)
 		apps := []*proto.App{
+			{
+				Slug:        "aaa",
+				DisplayName: "aaa",
+			},
 			{
 				Slug:  "aaa-code-server",
 				Order: 4,
@@ -2560,6 +2564,9 @@ func TestWorkspaceResource(t *testing.T) {
 				Slug:  "bbb-code-server",
 				Order: 3,
 			},
+			{
+				Slug: "bbb",
+			},
 		}
 		version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, &echo.Responses{
 			Parse: echo.ParseComplete,
@@ -2591,9 +2598,11 @@ func TestWorkspaceResource(t *testing.T) {
 		require.NoError(t, err)
 		require.Len(t, workspace.LatestBuild.Resources[0].Agents, 1)
 		agent := workspace.LatestBuild.Resources[0].Agents[0]
-		require.Len(t, agent.Apps, 2)
-		require.Equal(t, apps[1].Slug, agent.Apps[0].Slug)
-		require.Equal(t, apps[0].Slug, agent.Apps[1].Slug)
+		require.Len(t, agent.Apps, 4)
+		require.Equal(t, "bbb", agent.Apps[0].Slug)             // empty-display-name < "aaa"
+		require.Equal(t, "aaa", agent.Apps[1].Slug)             // no order < any order
+		require.Equal(t, "bbb-code-server", agent.Apps[2].Slug) // order = 3 < order = 4
+		require.Equal(t, "aaa-code-server", agent.Apps[3].Slug)
 	})
 
 	t.Run("Metadata", func(t *testing.T) {
