test: Skip tests that send os.Interrupt to test pid (#7695)

mafredri · web-flow · commit 05efd6432047 · 2023-05-26T16:17:09.000+03:00
This can cause test flakes due to clitest commands running in memory and
listening to interrupt signals.
diff --git a/cli/cliui/provisionerjob_test.go b/cli/cliui/provisionerjob_test.go
@@ -82,6 +82,8 @@ func TestProvisionerJob(t *testing.T) {
 	// This cannot be ran in parallel because it uses a signal.
 	// nolint:paralleltest
 	t.Run("Cancel", func(t *testing.T) {
+		t.Skip("This test issues an interrupt signal which will propagate to the test runner.")
+
 		if runtime.GOOS == "windows" {
 			// Sending interrupt signal isn't supported on Windows!
 			t.SkipNow()
diff --git a/cli/server_test.go b/cli/server_test.go
@@ -1491,6 +1491,8 @@ func TestServer_Production(t *testing.T) {
 
 //nolint:tparallel,paralleltest // This test cannot be run in parallel due to signal handling.
 func TestServer_Shutdown(t *testing.T) {
+	t.Skip("This test issues an interrupt signal which will propagate to the test runner.")
+
 	if runtime.GOOS == "windows" {
 		// Sending interrupt signal isn't supported on Windows!
 		t.SkipNow()
