Skip to content

Commit 092a3ca

Browse files
aslilacaslilac
committed
I hate eslint so much right now
1 parent 8a1cbba commit 092a3ca

File tree

15 files changed

+16
-19
lines changed

15 files changed

+16
-19
lines changed

‎site/src/components/Filter/filter.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import Box from "@mui/material/Box";
1+
/* eslint-disable eslint-comments/no-unlimited-disable -- no u */
2+
/* eslint-disable -- no u */
23
import TextField from "@mui/material/TextField";
34
import Button, { type ButtonProps } from "@mui/material/Button";
45
import Menu, { type MenuProps } from "@mui/material/Menu";
@@ -132,7 +133,7 @@ const BaseSkeleton = (props: SkeletonProps) => {
132133
height={36}
133134
{...props}
134135
css={(theme) => ({
135-
bgcolor: theme.palette.background.paperLight,
136+
backgroundColor: theme.palette.background.paperLight,
136137
borderRadius: "6px",
137138
})}
138139
/>
@@ -593,6 +594,7 @@ function SearchMenu<TOption extends { label: string; value: string }>({
593594
height: 40,
594595
borderBottom: `1px solid ${theme.palette.divider}`,
595596
}}
597+
// eslint-disable-next-line jsx-a11y/no-noninteractive-element-interactions -- try to figure out if we actually need this
596598
onKeyDown={(e) => {
597599
e.stopPropagation();
598600
if (e.key === "ArrowDown" && menuListRef.current) {

‎site/src/components/Resources/PortForwardButton.stories.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import Box from "@mui/material/Box";
21
import { PortForwardPopoverView } from "./PortForwardButton";
32
import type { Meta, StoryObj } from "@storybook/react";
43
import {

‎site/src/components/UserAutocomplete/UserAutocomplete.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import {
1111
type FC,
1212
useState,
1313
} from "react";
14-
import Box from "@mui/material/Box";
1514
import { useDebouncedFunction } from "hooks/debounce";
1615
import { useQuery } from "react-query";
1716
import { users } from "api/queries/users";

‎site/src/components/WorkspaceBuildLogs/WorkspaceBuildLogs.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
import dayjs from "dayjs";
2-
import {
3-
type ComponentProps,
4-
type FC,
5-
Fragment,
6-
type HTMLAttributes,
7-
} from "react";
2+
import { type FC, Fragment, type HTMLAttributes } from "react";
83
import type { ProvisionerJobLog } from "api/typesGenerated";
94
import { MONOSPACE_FONT_FAMILY } from "theme/constants";
105
import { Logs } from "./Logs";

‎site/src/components/WorkspaceOutdatedTooltip/WorkspaceOutdatedTooltip.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import RefreshIcon from "@mui/icons-material/Refresh";
22
import InfoIcon from "@mui/icons-material/InfoOutlined";
3-
import Box from "@mui/material/Box";
43
import Skeleton from "@mui/material/Skeleton";
54
import Link from "@mui/material/Link";
65
import { type FC } from "react";

‎site/src/hooks/useClassName.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/* eslint-disable react-hooks/exhaustive-deps -- false positives */
2+
13
import { css } from "@emotion/css";
24
import { type DependencyList, useMemo } from "react";
35
import { type Theme, useTheme } from "@emotion/react";

‎site/src/pages/GroupsPage/GroupsPageView.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import type { Group } from "api/typesGenerated";
2727
import { GroupAvatar } from "components/GroupAvatar/GroupAvatar";
2828
import { docs } from "utils/docs";
2929
import Skeleton from "@mui/material/Skeleton";
30-
import { Box } from "@mui/system";
3130
import { AvatarDataSkeleton } from "components/AvatarData/AvatarDataSkeleton";
3231

3332
export type GroupsPageViewProps = {

‎site/src/pages/IconsPage/IconsPage.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import TextField from "@mui/material/TextField";
22
import InputAdornment from "@mui/material/InputAdornment";
33
import Tooltip from "@mui/material/Tooltip";
44
import IconButton from "@mui/material/IconButton";
5-
import Box from "@mui/material/Box";
65
import Link from "@mui/material/Link";
76
import SearchIcon from "@mui/icons-material/SearchOutlined";
87
import ClearIcon from "@mui/icons-material/CloseOutlined";

‎site/src/pages/TemplatePage/TemplateEmbedPage/TemplateEmbedPage.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import CheckOutlined from "@mui/icons-material/CheckOutlined";
22
import FileCopyOutlined from "@mui/icons-material/FileCopyOutlined";
3-
import Box from "@mui/material/Box";
43
import Button from "@mui/material/Button";
54
import FormControlLabel from "@mui/material/FormControlLabel";
65
import Radio from "@mui/material/Radio";

‎site/src/pages/TemplatePage/TemplateInsightsPage/IntervalMenu.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import CheckOutlined from "@mui/icons-material/CheckOutlined";
22
import ExpandMoreOutlined from "@mui/icons-material/ExpandMoreOutlined";
3-
import Box from "@mui/material/Box";
43
import Button from "@mui/material/Button";
54
import Menu from "@mui/material/Menu";
65
import MenuItem from "@mui/material/MenuItem";

‎site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import {
2222
type FC,
2323
type ReactNode,
2424
HTMLAttributes,
25+
useId,
2526
} from "react";
2627
import chroma from "chroma-js";
2728
import { subDays, addWeeks, format } from "date-fns";
@@ -622,6 +623,7 @@ const ParameterUsageLabel: FC<ParameterUsageLabelProps> = ({
622623
usage,
623624
parameter,
624625
}) => {
626+
const ariaId = useId();
625627
const theme = useTheme();
626628

627629
if (parameter.options) {
@@ -640,16 +642,18 @@ const ParameterUsageLabel: FC<ParameterUsageLabelProps> = ({
640642
{icon && (
641643
<div css={{ width: 16, height: 16, lineHeight: 1 }}>
642644
<img
645+
alt=""
643646
src={icon}
644647
css={{
645648
objectFit: "contain",
646649
width: "100%",
647650
height: "100%",
648651
}}
652+
aria-labelledby={ariaId}
649653
/>
650654
</div>
651655
)}
652-
{label}
656+
<span id={ariaId}>{label}</span>
653657
</div>
654658
);
655659
}

‎site/src/pages/WorkspacesPage/BatchActions.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { useTheme } from "@emotion/react";
22
import TextField from "@mui/material/TextField";
3-
import { Box } from "@mui/system";
43
import { deleteWorkspace, startWorkspace, stopWorkspace } from "api/api";
54
import type { Workspace } from "api/typesGenerated";
65
import { ConfirmDialog } from "components/Dialogs/ConfirmDialog/ConfirmDialog";

‎site/src/pages/WorkspacesPage/WorkspacesButton.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import {
55
Link as RouterLink,
66
LinkProps as RouterLinkProps,
77
} from "react-router-dom";
8-
import Box from "@mui/system/Box";
98
import Button from "@mui/material/Button";
109
import Link from "@mui/material/Link";
1110
import AddIcon from "@mui/icons-material/AddOutlined";

‎site/src/pages/WorkspacesPage/WorkspacesPageView.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import {
1515
PaginationStatus,
1616
TableToolbar,
1717
} from "components/TableToolbar/TableToolbar";
18-
import Box from "@mui/material/Box";
1918
import DeleteOutlined from "@mui/icons-material/DeleteOutlined";
2019
import { WorkspacesButton } from "./WorkspacesButton";
2120
import { UseQueryResult } from "react-query";

‎site/src/pages/WorkspacesPage/WorkspacesSearchBox.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
/* eslint-disable eslint-comments/no-unlimited-disable -- no u */
2+
/* eslint-disable -- no u */
3+
14
/**
25
* @file Defines a controlled searchbox component for processing form state.
36
*
@@ -49,6 +52,7 @@ export const SearchBox = forwardRef(function SearchBox(
4952
height: "40px",
5053
borderBottom: `1px solid ${theme.palette.divider}`,
5154
}}
55+
// eslint-disable-next-line jsx-a11y/no-noninteractive-element-interactions -- try to figure out if we actually need this
5256
onKeyDown={onKeyDown}
5357
>
5458
<div css={{ width: 18 }}>

0 commit comments

Comments
 (0)