Fix minor lint errors

BrunoQuaresma · BrunoQuaresma · commit 0c1f210c0b7b · 2023-07-27T13:34:27.000Z
diff --git a/site/src/components/AuditLogRow/AuditLogDiff/AuditLogDiff.tsx b/site/src/components/AuditLogRow/AuditLogDiff/AuditLogDiff.tsx
@@ -19,7 +19,7 @@ const getDiffValue = (value: unknown): string => {
     return "null"
   }
 
-  return value.toString()
+  return String(value)
 }
 
 export const AuditLogDiff: FC<{ diff: AuditLog["diff"] }> = ({ diff }) => {
diff --git a/site/src/components/Icons/VSCodeIcon.tsx b/site/src/components/Icons/VSCodeIcon.tsx
@@ -5,7 +5,7 @@ export const VSCodeIcon = (props: SvgIconProps) => (
     <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100" fill="none">
       <mask
         id="vscode_mask0"
-        mask-type="alpha"
+        style={{ maskType: "alpha" }}
         maskUnits="userSpaceOnUse"
         x="0"
         y="0"
diff --git a/site/src/components/Icons/VSCodeInsidersIcon.tsx b/site/src/components/Icons/VSCodeInsidersIcon.tsx
@@ -11,7 +11,7 @@ export const VSCodeInsidersIcon = (props: SvgIconProps) => (
     >
       <mask
         id="mask0"
-        mask-type="alpha"
+        style={{ maskType: "alpha" }}
         maskUnits="userSpaceOnUse"
         x="0"
         y="0"
diff --git a/site/src/components/LicenseBanner/LicenseBannerView.tsx b/site/src/components/LicenseBanner/LicenseBannerView.tsx
@@ -65,7 +65,7 @@ export const LicenseBannerView: React.FC<LicenseBannerViewProps> = ({
           <Expander expanded={showDetails} setExpanded={setShowDetails}>
             <ul className={styles.list}>
               {messages.map((message) => (
-                <li className={styles.listItem} key={`${message}`}>
+                <li className={styles.listItem} key={message}>
                   {message}
                 </li>
               ))}
diff --git a/site/src/components/ServiceBanner/ServiceBannerView.tsx b/site/src/components/ServiceBanner/ServiceBannerView.tsx
@@ -31,7 +31,7 @@ export const ServiceBannerView: React.FC<ServiceBannerViewProps> = ({
   ]
   return (
     <div
-      className={`${styles.container}`}
+      className={styles.container}
       style={{ backgroundColor: backgroundColor }}
     >
       {preview && <Pill text="Preview" type="info" lightBorder />}
diff --git a/site/src/contexts/useProxyLatency.ts b/site/src/contexts/useProxyLatency.ts
@@ -135,7 +135,7 @@ export const useProxyLatency = (
     // dispatchProxyLatenciesGuarded will assign the latency to the proxy
     // via the reducer. But it will only do so if the performance entry is
     // a resource entry that we care about.
-    const dispatchProxyLatenciesGuarded = (entry: PerformanceEntry): void => {
+    const dispatchProxyLatenciesGuarded = (entry: PerformanceEntry) => {
       if (entry.entryType !== "resource") {
         // We should never get these, but just in case.
         return
@@ -208,7 +208,7 @@ export const useProxyLatency = (
     })
 
     // When all the proxy requests finish
-    Promise.all(proxyRequests)
+    void Promise.all(proxyRequests)
       // TODO: If there is an error on any request, we might want to store some indicator of that?
       .finally(() => {
         // takeRecords will return any entries that were not called via the callback yet.

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ const getDiffValue = (value: unknown): string => {`
`19`	`19`	`return "null"`
`20`	`20`	`}`
`21`	`21`
`22`		`- return value.toString()`
	`22`	`+ return String(value)`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`export const AuditLogDiff: FC<{ diff: AuditLog["diff"] }> = ({ diff }) => {`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ export const VSCodeInsidersIcon = (props: SvgIconProps) => (`
`11`	`11`	`>`
`12`	`12`	`<mask`
`13`	`13`	`id="mask0"`
`14`		`- mask-type="alpha"`
	`14`	`+ style={{ maskType: "alpha" }}`
`15`	`15`	`maskUnits="userSpaceOnUse"`
`16`	`16`	`x="0"`
`17`	`17`	`y="0"`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ export const ServiceBannerView: React.FC<ServiceBannerViewProps> = ({`
`31`	`31`	`]`
`32`	`32`	`return (`
`33`	`33`	`<div`
`34`		- className={`${styles.container}`}
	`34`	`+ className={styles.container}`
`35`	`35`	`style={{ backgroundColor: backgroundColor }}`
`36`	`36`	`>`
`37`	`37`	`{preview && <Pill text="Preview" type="info" lightBorder />}`