Skip to content

Commit 0c6e367

Browse files
committed
chore: Fix PR comments
1 parent 3c68823 commit 0c6e367

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

site/site.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -461,14 +461,14 @@ func filterFiles(files []fs.DirEntry, names ...string) []fs.DirEntry {
461461
return filtered
462462
}
463463

464-
func extractBin(dest string, r io.Reader) (n int, err error) {
464+
func extractBin(dest string, r io.Reader) (numExtraced int, err error) {
465465
opts := []zstd.DOption{
466466
// Concurrency doesn't help us when decoding the tar and
467467
// can actually slow us down.
468468
zstd.WithDecoderConcurrency(1),
469-
// Ignoring checksums give us a slight performance
470-
// increase, we assume no corruption due to embedding.
471-
zstd.IgnoreChecksum(true),
469+
// Ignoring checksums can give a slight performance
470+
// boost but it's probalby not worth the reduced safety.
471+
zstd.IgnoreChecksum(false),
472472
// Allow the decoder to use more memory giving us a 2-3x
473473
// performance boost.
474474
zstd.WithDecoderLowmem(false),
@@ -480,6 +480,7 @@ func extractBin(dest string, r io.Reader) (n int, err error) {
480480
defer zr.Close()
481481

482482
tr := tar.NewReader(zr)
483+
n := 0
483484
for {
484485
h, err := tr.Next()
485486
if err != nil {

0 commit comments

Comments
 (0)