wip(drop): add notes

jsjoeio · jsjoeio · commit 0ca4c354eab4 · 2022-09-20T16:44:04.000Z
diff --git a/site/src/pages/TemplatePage/TemplatePage.tsx b/site/src/pages/TemplatePage/TemplatePage.tsx
@@ -50,6 +50,14 @@ export const TemplatePage: FC<React.PropsWithChildren<unknown>> = () => {
     templateSend("DELETE")
   }
 
+  // TODO@jsjoeio - handle other scenario
+  // If template doesn't exist, navigate to templates
+  // display error notification
+  // Probably going to need to modify the service
+  // site/src/xServices/template/templateXService.ts
+  // For an example, look here: site/src/xServices/workspaces/workspacesXService.ts
+  // displayError is the function we want to use
+
   if (isLoading) {
     return <Loader />
   }
diff --git a/site/src/pages/index.tsx b/site/src/pages/index.tsx
@@ -2,5 +2,11 @@ import { FC } from "react"
 import { Navigate } from "react-router-dom"
 
 export const IndexPage: FC = () => {
+  // TODO@jsjoeio - here's what we need to do:
+  /*
+  1. check query params for template
+  2. if none, navigate to /workspaces
+  3. if some, navigate to /templates/<template>
+  */
   return <Navigate to="/workspaces" replace />
 }

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,14 @@ export const TemplatePage: FC<React.PropsWithChildren<unknown>> = () => {`
`50`	`50`	`templateSend("DELETE")`
`51`	`51`	`}`
`52`	`52`
	`53`	`+ // TODO@jsjoeio - handle other scenario`
	`54`	`+ // If template doesn't exist, navigate to templates`
	`55`	`+ // display error notification`
	`56`	`+ // Probably going to need to modify the service`
	`57`	`+ // site/src/xServices/template/templateXService.ts`
	`58`	`+ // For an example, look here: site/src/xServices/workspaces/workspacesXService.ts`
	`59`	`+ // displayError is the function we want to use`
	`60`	`+`
`53`	`61`	`if (isLoading) {`
`54`	`62`	`return <Loader />`
`55`	`63`	`}`