add interface method to allow api crud

Emyrk · Emyrk · commit 0df7f28209e5 · 2024-09-09T16:31:06.000-05:00
diff --git a/coderd/idpsync/group.go b/coderd/idpsync/group.go
@@ -28,6 +28,9 @@ func (AGPLIDPSync) GroupSyncEnabled() bool {
 	// AGPL does not support syncing groups.
 	return false
 }
+func (s AGPLIDPSync) GroupSyncSettings() runtimeconfig.RuntimeEntry[*GroupSyncSettings] {
+	return s.Group
+}
 
 func (s AGPLIDPSync) ParseGroupClaims(_ context.Context, _ jwt.MapClaims) (GroupParams, *HTTPError) {
 	return GroupParams{
diff --git a/coderd/idpsync/idpsync.go b/coderd/idpsync/idpsync.go
@@ -36,9 +36,12 @@ type IDPSync interface {
 	// ParseGroupClaims takes claims from an OIDC provider, and returns the params
 	// for group syncing. Most of the logic happens in SyncGroups.
 	ParseGroupClaims(ctx context.Context, mergedClaims jwt.MapClaims) (GroupParams, *HTTPError)
-
 	// SyncGroups assigns and removes users from groups based on the provided params.
 	SyncGroups(ctx context.Context, db database.Store, user database.User, params GroupParams) error
+	// GroupSyncSettings is exposed for the API to implement CRUD operations
+	// on the settings used by IDPSync. This entry is thread safe and can be
+	// accessed concurrently. The settings are stored in the database.
+	GroupSyncSettings() runtimeconfig.RuntimeEntry[*GroupSyncSettings]
 }
 
 // AGPLIDPSync is the configuration for syncing user information from an external

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,9 @@ func (AGPLIDPSync) GroupSyncEnabled() bool {`
`28`	`28`	`// AGPL does not support syncing groups.`
`29`	`29`	`return false`
`30`	`30`	`}`
	`31`	`+func (s AGPLIDPSync) GroupSyncSettings() runtimeconfig.RuntimeEntry[*GroupSyncSettings] {`
	`32`	`+ return s.Group`
	`33`	`+}`
`31`	`34`
`32`	`35`	`func (s AGPLIDPSync) ParseGroupClaims(_ context.Context, _ jwt.MapClaims) (GroupParams, *HTTPError) {`
`33`	`36`	`return GroupParams{`