lock more things

johnstcn · johnstcn · commit 0e3b9ffb2ecd · 2023-01-30T15:21:00.000Z
diff --git a/coderd/coderdtest/authorize.go b/coderd/coderdtest/authorize.go
@@ -661,6 +661,8 @@ func (r *RecordingAuthorizer) Authorize(ctx context.Context, subject rbac.Subjec
 }
 
 func (r *RecordingAuthorizer) Prepare(_ context.Context, subject rbac.Subject, action rbac.Action, _ string) (rbac.PreparedAuthorized, error) {
+	r.RLock()
+	defer r.RUnlock()
 	if r.Wrapped == nil {
 		panic("Developer error: RecordingAuthorizer.Wrapped is nil")
 	}
@@ -673,6 +675,8 @@ func (r *RecordingAuthorizer) Prepare(_ context.Context, subject rbac.Subject, a
 }
 
 func (r *RecordingAuthorizer) reset() {
+	r.Lock()
+	defer r.Unlock()
 	r.Called = nil
 }
 
@@ -706,6 +710,8 @@ func (f *fakePreparedAuthorizer) CompileToSQL(_ context.Context, _ regosql.Conve
 // LastCall is implemented to support legacy tests.
 // Deprecated
 func (r *RecordingAuthorizer) LastCall() *authCall {
+	r.RLock()
+	defer r.RUnlock()
 	if len(r.Called) == 0 {
 		return nil
 	}

Original file line number	Diff line number	Diff line change
`@@ -661,6 +661,8 @@ func (r *RecordingAuthorizer) Authorize(ctx context.Context, subject rbac.Subjec`
`661`	`661`	`}`
`662`	`662`
`663`	`663`	`func (r *RecordingAuthorizer) Prepare(_ context.Context, subject rbac.Subject, action rbac.Action, _ string) (rbac.PreparedAuthorized, error) {`
	`664`	`+ r.RLock()`
	`665`	`+ defer r.RUnlock()`
`664`	`666`	`if r.Wrapped == nil {`
`665`	`667`	`panic("Developer error: RecordingAuthorizer.Wrapped is nil")`
`666`	`668`	`}`
`@@ -673,6 +675,8 @@ func (r *RecordingAuthorizer) Prepare(_ context.Context, subject rbac.Subject, a`
`673`	`675`	`}`
`674`	`676`
`675`	`677`	`func (r *RecordingAuthorizer) reset() {`
	`678`	`+ r.Lock()`
	`679`	`+ defer r.Unlock()`
`676`	`680`	`r.Called = nil`
`677`	`681`	`}`
`678`	`682`
`@@ -706,6 +710,8 @@ func (f *fakePreparedAuthorizer) CompileToSQL(_ context.Context, _ regosql.Conve`
`706`	`710`	`// LastCall is implemented to support legacy tests.`
`707`	`711`	`// Deprecated`
`708`	`712`	`func (r RecordingAuthorizer) LastCall() authCall {`
	`713`	`+ r.RLock()`
	`714`	`+ defer r.RUnlock()`
`709`	`715`	`if len(r.Called) == 0 {`
`710`	`716`	`return nil`
`711`	`717`	`}`