fix: minor fixes

evgeniy-scherbina · evgeniy-scherbina · commit 0e3cc40d08ae · 2025-05-19T19:29:06.000Z
diff --git a/enterprise/coderd/prebuilds/reconcile.go b/enterprise/coderd/prebuilds/reconcile.go
@@ -491,7 +491,7 @@ func (c *StoreReconciler) notifyPrebuildFailureLimitReached(ctx context.Context,
 
 	// Send notification to template admins.
 	if c.notifEnq == nil {
-		c.logger.Warn(ctx, "notification enqueuer not set, cannot send resource replacement notification(s)")
+		c.logger.Warn(ctx, "notification enqueuer not set, cannot send prebuild is hard limited notification(s)")
 		return nil
 	}
 
diff --git a/enterprise/coderd/prebuilds/reconcile_test.go b/enterprise/coderd/prebuilds/reconcile_test.go
@@ -758,7 +758,7 @@ func TestSkippingHardLimitedPresets(t *testing.T) {
 
 			// When hard limit is reached, a notification should be sent.
 			matching := fakeEnqueuer.Sent(func(notification *notificationstest.FakeNotification) bool {
-				if !assert.Equal(t, notification.TemplateID, notifications.PrebuildFailureLimitReached, "unexpected template") {
+				if !assert.Equal(t, notifications.PrebuildFailureLimitReached, notification.TemplateID, "unexpected template") {
 					return false
 				}
 

Original file line number	Diff line number	Diff line change
`@@ -491,7 +491,7 @@ func (c *StoreReconciler) notifyPrebuildFailureLimitReached(ctx context.Context,`
`491`	`491`
`492`	`492`	`// Send notification to template admins.`
`493`	`493`	`if c.notifEnq == nil {`
`494`		`- c.logger.Warn(ctx, "notification enqueuer not set, cannot send resource replacement notification(s)")`
	`494`	`+ c.logger.Warn(ctx, "notification enqueuer not set, cannot send prebuild is hard limited notification(s)")`
`495`	`495`	`return nil`
`496`	`496`	`}`
`497`	`497`
Original file line number	Diff line number	Diff line change
`@@ -758,7 +758,7 @@ func TestSkippingHardLimitedPresets(t *testing.T) {`
`758`	`758`
`759`	`759`	`// When hard limit is reached, a notification should be sent.`
`760`	`760`	`matching := fakeEnqueuer.Sent(func(notification *notificationstest.FakeNotification) bool {`
`761`		`- if !assert.Equal(t, notification.TemplateID, notifications.PrebuildFailureLimitReached, "unexpected template") {`
	`761`	`+ if !assert.Equal(t, notifications.PrebuildFailureLimitReached, notification.TemplateID, "unexpected template") {`
`762`	`762`	`return false`
`763`	`763`	`}`
`764`	`764`