Update nav

BrunoQuaresma · BrunoQuaresma · commit 0e6e65155676 · 2023-03-15T14:16:11.000Z
diff --git a/site/src/components/DropdownButton/ActionCtas.tsx b/site/src/components/DropdownButton/ActionCtas.tsx
@@ -54,9 +54,9 @@ export const ChangeVersionButton: FC<
   )
 }
 
-export const BuildParametersButton: FC<
-  React.PropsWithChildren<WorkspaceAction>
-> = ({ handleAction }) => {
+export const SettingsButton: FC<React.PropsWithChildren<WorkspaceAction>> = ({
+  handleAction,
+}) => {
   const styles = useStyles()
   const { t } = useTranslation("workspacePage")
 
@@ -67,7 +67,7 @@ export const BuildParametersButton: FC<
       startIcon={<SettingsOutlined />}
       onClick={handleAction}
     >
-      {t("actionButton.buildParameters")}
+      {t("actionButton.settings")}
     </Button>
   )
 }
diff --git a/site/src/components/Workspace/Workspace.tsx b/site/src/components/Workspace/Workspace.tsx
@@ -43,7 +43,7 @@ export interface WorkspaceProps {
   handleUpdate: () => void
   handleCancel: () => void
   handleChangeVersion: () => void
-  handleBuildParameters: () => void
+  handleSettings: () => void
   isUpdating: boolean
   workspace: TypesGen.Workspace
   resources?: TypesGen.WorkspaceResource[]
@@ -70,7 +70,7 @@ export const Workspace: FC<React.PropsWithChildren<WorkspaceProps>> = ({
   handleUpdate,
   handleCancel,
   handleChangeVersion,
-  handleBuildParameters,
+  handleSettings,
   workspace,
   isUpdating,
   resources,
@@ -136,7 +136,7 @@ export const Workspace: FC<React.PropsWithChildren<WorkspaceProps>> = ({
               handleUpdate={handleUpdate}
               handleCancel={handleCancel}
               handleChangeVersion={handleChangeVersion}
-              handleBuildParameters={handleBuildParameters}
+              handleSettings={handleSettings}
               isUpdating={isUpdating}
             />
           </Stack>
diff --git a/site/src/components/WorkspaceActions/WorkspaceActions.test.tsx b/site/src/components/WorkspaceActions/WorkspaceActions.test.tsx
@@ -20,7 +20,7 @@ const renderComponent = async (props: Partial<WorkspaceActionsProps> = {}) => {
       handleUpdate={jest.fn()}
       handleCancel={jest.fn()}
       handleChangeVersion={jest.fn()}
-      handleBuildParameters={jest.fn()}
+      handleSettings={jest.fn()}
       isUpdating={false}
     />,
   )
@@ -40,7 +40,7 @@ const renderAndClick = async (props: Partial<WorkspaceActionsProps> = {}) => {
       handleUpdate={jest.fn()}
       handleCancel={jest.fn()}
       handleChangeVersion={jest.fn()}
-      handleBuildParameters={jest.fn()}
+      handleSettings={jest.fn()}
       isUpdating={false}
     />,
   )
diff --git a/site/src/components/WorkspaceActions/WorkspaceActions.tsx b/site/src/components/WorkspaceActions/WorkspaceActions.tsx
@@ -7,7 +7,7 @@ import {
   ChangeVersionButton,
   DeleteButton,
   DisabledButton,
-  BuildParametersButton,
+  SettingsButton,
   StartButton,
   StopButton,
   UpdateButton,
@@ -24,7 +24,7 @@ export interface WorkspaceActionsProps {
   handleUpdate: () => void
   handleCancel: () => void
   handleChangeVersion: () => void
-  handleBuildParameters: () => void
+  handleSettings: () => void
   isUpdating: boolean
   children?: ReactNode
 }
@@ -39,7 +39,7 @@ export const WorkspaceActions: FC<WorkspaceActionsProps> = ({
   handleUpdate,
   handleCancel,
   handleChangeVersion,
-  handleBuildParameters,
+  handleSettings,
   isUpdating,
 }) => {
   const { t } = useTranslation("workspacePage")
@@ -59,7 +59,7 @@ export const WorkspaceActions: FC<WorkspaceActionsProps> = ({
       <ChangeVersionButton handleAction={handleChangeVersion} />
     ),
     [ButtonTypesEnum.buildParameters]: (
-      <BuildParametersButton handleAction={handleBuildParameters} />
+      <SettingsButton handleAction={handleSettings} />
     ),
     [ButtonTypesEnum.start]: <StartButton handleAction={handleStart} />,
     [ButtonTypesEnum.starting]: (
diff --git a/site/src/i18n/en/workspacePage.json b/site/src/i18n/en/workspacePage.json
@@ -29,7 +29,7 @@
     "stopping": "Stopping...",
     "deleting": "Deleting...",
     "changeVersion": "Change version",
-    "buildParameters": "Build parameters"
+    "settings": "Settings"
   },
   "disabledButton": {
     "canceling": "Canceling",
diff --git a/site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx b/site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx
@@ -113,7 +113,7 @@ export const WorkspaceReadyPage = ({
         handleUpdate={() => workspaceSend({ type: "UPDATE" })}
         handleCancel={() => workspaceSend({ type: "CANCEL" })}
         handleChangeVersion={() => navigate("change-version")}
-        handleBuildParameters={() => navigate("build-parameters")}
+        handleSettings={() => navigate("settings")}
         resources={workspace.latest_build.resources}
         builds={builds}
         canUpdateWorkspace={canUpdateWorkspace}

Original file line number	Diff line number	Diff line change
`@@ -54,9 +54,9 @@ export const ChangeVersionButton: FC<`
`54`	`54`	`)`
`55`	`55`	`}`
`56`	`56`
`57`		`-export const BuildParametersButton: FC<`
`58`		`- React.PropsWithChildren<WorkspaceAction>`
`59`		`-> = ({ handleAction }) => {`
	`57`	`+export const SettingsButton: FC<React.PropsWithChildren<WorkspaceAction>> = ({`
	`58`	`+ handleAction,`
	`59`	`+}) => {`
`60`	`60`	`const styles = useStyles()`
`61`	`61`	`const { t } = useTranslation("workspacePage")`
`62`	`62`
`@@ -67,7 +67,7 @@ export const BuildParametersButton: FC<`
`67`	`67`	`startIcon={<SettingsOutlined />}`
`68`	`68`	`onClick={handleAction}`
`69`	`69`	`>`
`70`		`- {t("actionButton.buildParameters")}`
	`70`	`+ {t("actionButton.settings")}`
`71`	`71`	`</Button>`
`72`	`72`	`)`
`73`	`73`	`}`