chore: add additional tests

jaaydenh · jaaydenh · commit 0ecf02421f49 · 2024-08-28T21:55:38.000Z
diff --git a/site/src/pages/ManagementSettingsPage/CustomRolesPage/CreateEditRolePageView.stories.tsx b/site/src/pages/ManagementSettingsPage/CustomRolesPage/CreateEditRolePageView.stories.tsx
@@ -1,10 +1,12 @@
 import type { Meta, StoryObj } from "@storybook/react";
 import {
 	MockRoleWithOrgPermissions,
+	MockRole2WithOrgPermissions,
 	assignableRole,
 	mockApiError,
 } from "testHelpers/entities";
 import { CreateEditRolePageView } from "./CreateEditRolePageView";
+import { userEvent, within, expect } from "@storybook/test";
 
 const meta: Meta<typeof CreateEditRolePageView> = {
 	title: "pages/OrganizationCreateEditRolePage",
@@ -25,6 +27,16 @@ export const Default: Story = {
 	},
 };
 
+export const CheckboxIndeterminate: Story = {
+	args: {
+		role: assignableRole(MockRole2WithOrgPermissions, true),
+		onSubmit: () => null,
+		isLoading: false,
+		organizationName: "my-org",
+		canAssignOrgRole: true,
+	},
+};
+
 export const WithError: Story = {
 	args: {
 		role: assignableRole(MockRoleWithOrgPermissions, true),
@@ -61,3 +73,17 @@ export const ShowAllResources: Story = {
 		allResources: true,
 	},
 };
+
+export const ToggleParentCheckbox: Story = {
+	play: async ({ canvasElement }) => {
+		const user = userEvent.setup();
+		const canvas = within(canvasElement);
+		const checkbox = await canvas
+			.getByTestId("audit_log")
+			.getElementsByTagName("input")[0];
+		await user.click(checkbox);
+		await expect(checkbox).toBeChecked();
+		await user.click(checkbox);
+		await expect(checkbox).not.toBeChecked();
+	},
+};
diff --git a/site/src/pages/ManagementSettingsPage/CustomRolesPage/CreateEditRolePageView.tsx b/site/src/pages/ManagementSettingsPage/CustomRolesPage/CreateEditRolePageView.tsx
@@ -334,6 +334,7 @@ const PermissionCheckboxGroup: FC<PermissionCheckboxGroupProps> = ({
 							checkedActions.length > 0 &&
 							checkedActions.length < Object.keys(value).length
 						}
+						data-testid={`${resourceKey}`}
 						onChange={(e) =>
 							handleResourceCheckChange(
 								e,
@@ -416,7 +417,7 @@ const styles = {
 	}),
 	actionItem: {
 		display: "grid",
-		gridTemplateColumns: "270px 3fr",
+		gridTemplateColumns: "270px 1fr",
 	},
 } satisfies Record<string, Interpolation<Theme>>;
 
diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -391,6 +391,21 @@ export const MockRoleWithOrgPermissions: TypesGen.Role = {
 	user_permissions: [],
 };
 
+export const MockRole2WithOrgPermissions: TypesGen.Role = {
+	name: "my-role-1",
+	display_name: "My Role 1",
+	organization_id: MockOrganization.id,
+	site_permissions: [],
+	organization_permissions: [
+		{
+			negate: false,
+			resource_type: "audit_log",
+			action: "create",
+		},
+	],
+	user_permissions: [],
+};
+
 // assignableRole takes a role and a boolean. The boolean implies if the
 // actor can assign (add/remove) the role from other users.
 export function assignableRole(
