move noop response writer

Emyrk · Emyrk · commit 0f26830fb9bb · 2025-04-08T16:21:51.000-05:00
diff --git a/coderd/httpapi/noop.go b/coderd/httpapi/noop.go
@@ -0,0 +1,10 @@
+package httpapi
+
+import "net/http"
+
+// NoopResponseWriter is a response writer that does nothing.
+type NoopResponseWriter struct{}
+
+func (NoopResponseWriter) Header() http.Header         { return http.Header{} }
+func (NoopResponseWriter) Write(p []byte) (int, error) { return len(p), nil }
+func (NoopResponseWriter) WriteHeader(int)             {}
diff --git a/coderd/httpmw/noop.go b/coderd/httpmw/noop.go
diff --git a/coderd/httpmw/userparam.go b/coderd/httpmw/userparam.go
@@ -59,7 +59,7 @@ func ExtractUserParamOptional(db database.Store) func(http.Handler) http.Handler
 		return http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
 			ctx := r.Context()
 
-			user, ok := ExtractUserContext(ctx, db, &noopResponseWriter{}, r)
+			user, ok := ExtractUserContext(ctx, db, &httpapi.NoopResponseWriter{}, r)
 			if ok {
 				ctx = context.WithValue(ctx, userParamContextKey{}, user)
 			}

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ func ExtractUserParamOptional(db database.Store) func(http.Handler) http.Handler`
`59`	`59`	`return http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {`
`60`	`60`	`ctx := r.Context()`
`61`	`61`
`62`		`- user, ok := ExtractUserContext(ctx, db, &noopResponseWriter{}, r)`
	`62`	`+ user, ok := ExtractUserContext(ctx, db, &httpapi.NoopResponseWriter{}, r)`
`63`	`63`	`if ok {`
`64`	`64`	`ctx = context.WithValue(ctx, userParamContextKey{}, user)`
`65`	`65`	`}`